From: Jeff King <peff@peff.net>
To: Sverre Rabbelier <srabbelier@gmail.com>
Cc: Jonathan Nieder <jrnieder@gmail.com>,
Git List <git@vger.kernel.org>, Jakub Narebski <jnareb@gmail.com>
Subject: Re: non-empty index with git commit -a
Date: Wed, 16 Feb 2011 03:51:14 -0500 [thread overview]
Message-ID: <20110216085114.GA9413@sigill.intra.peff.net> (raw)
In-Reply-To: <AANLkTinbcHW+ja7T=PiCEorNdnK6W2DvA_c9F8JTEMKB@mail.gmail.com>
On Wed, Feb 16, 2011 at 08:18:18AM +0000, Sverre Rabbelier wrote:
> On Wed, Feb 16, 2011 at 03:20, Jonathan Nieder <jrnieder@gmail.com> wrote:
> > If I remember the discussion[1] correctly, by requiring a separate
> > add -u step (or commit -f -a) if the "I don't trust my fingers"
> > configuration is enabled.
>
> That would definitely work for me. The question then is, should git
> consider the index precious by default, or not? That is, should that
> value default to true in 1.8?
If we do not consider the index precious, then no, it should not be the
default. If we do consider it precious, then isn't this option fixing
one small case and leaving all of the others untouched?
I can just as easily run "git add -u", or "git add -p" on top of some
changes and then realize afterwards that I actually wanted the previous
index state.
The solution for that would be an index reflog.
-Peff
next prev parent reply other threads:[~2011-02-16 8:51 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-15 22:43 non-empty index with git commit -a Sverre Rabbelier
2011-02-16 2:36 ` Jeff King
2011-02-16 3:20 ` Jonathan Nieder
2011-02-16 3:27 ` Jeff King
2011-02-16 8:18 ` Sverre Rabbelier
2011-02-16 8:29 ` Nguyen Thai Ngoc Duy
2011-02-16 8:44 ` Jonathan Nieder
2011-02-16 8:51 ` Jeff King [this message]
2011-02-16 9:52 ` Sverre Rabbelier
2011-02-16 9:54 ` Jeff King
2011-02-16 9:58 ` Sverre Rabbelier
2011-02-16 10:06 ` Jeff King
2011-02-16 14:41 ` Michael J Gruber
2011-02-16 19:29 ` Jeff King
2011-02-16 18:51 ` Junio C Hamano
2011-02-16 19:36 ` Jeff King
2011-02-16 19:55 ` Junio C Hamano
2011-02-16 19:59 ` Jeff King
2011-02-16 21:03 ` Jakub Narebski
2011-02-16 21:46 ` Junio C Hamano
2011-02-16 22:34 ` Jeff King
2011-02-16 10:28 ` Matthieu Moy
2011-02-16 19:48 ` Jeff King
2011-02-16 18:47 ` Junio C Hamano
2011-02-16 9:05 ` Matthieu Moy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110216085114.GA9413@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=jnareb@gmail.com \
--cc=jrnieder@gmail.com \
--cc=srabbelier@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).