From: Charles Bailey <charles@hashpling.org>
To: Chris Packham <judge.packham@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] mergetool--lib: add support for beyond compare
Date: Fri, 18 Feb 2011 09:36:51 +0000 [thread overview]
Message-ID: <20110218093651.GA8700@hashpling.org> (raw)
In-Reply-To: <1298016553-2308-1-git-send-email-judge.packham@gmail.com>
On Fri, Feb 18, 2011 at 09:09:13PM +1300, Chris Packham wrote:
> Add support for Beyond Compare as a diff/merge tool.
>
> Signed-off-by: Chris Packham <judge.packham@gmail.com>
> ---
>
> I wasn't sure about whether git should have support for non-free external
> tools. Then I saw that support for Araxis had been added in b6f0621a, which
> I've used as a guide for this patch.
You right, there is no specific reason not to support non-free merge
tools in mergetool; the major issue is testing. The patch looks
reasonable but I would prefer to see independent confirmation -
especially on windows, Beyond Compares' most popular supported platform
- before this patch is merged.
Charles.
prev parent reply other threads:[~2011-02-18 9:46 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-18 8:09 [PATCH] mergetool--lib: add support for beyond compare Chris Packham
2011-02-18 9:36 ` Charles Bailey [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110218093651.GA8700@hashpling.org \
--to=charles@hashpling.org \
--cc=git@vger.kernel.org \
--cc=judge.packham@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).