From: Jeff King <peff@peff.net>
To: Will Palmer <wmpalmer@gmail.com>
Cc: Eric Wong <normalperson@yhbt.net>, git <git@vger.kernel.org>
Subject: Re: [BUG] git-svn fails to rename files with %20 in filename
Date: Wed, 23 Feb 2011 05:04:32 -0500 [thread overview]
Message-ID: <20110223100431.GD9222@sigill.intra.peff.net> (raw)
In-Reply-To: <1298393415.2286.18.camel@wpalmer.simply-domain>
On Tue, Feb 22, 2011 at 04:50:15PM +0000, Will Palmer wrote:
> > IOW, it looks like the path we hand to svn needs url-encoding even for
> > the local case (which make sense, as it is a file:// url). But I know
> > nothing about svn, so probably I am breaking some other weird non-url
> > local case. :)
> >
>
> Unless I've got my line-numbers mixed up, the commit which introduced
> the https-specific encoding behaviour,
> 29633bb91c git-svn: fix commiting renames over DAV with funky file names
>
> seems to be of the opinion that the bug did not effect file:// and
> svn:// URLs. Has something changed?
Yeah, what we are seeing definitely contradicts that commit. It's been
3.5 years; maybe something was tweaked in the subversion library? I
tried reading the code, but I got lost amidst all of the nasty perl
bindings. I couldn't find anything relevant in svn's changelog or in
google, either.
-Peff
next prev parent reply other threads:[~2011-02-23 10:04 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-21 10:12 [BUG] git-svn fails to rename files with %20 in filename Will Palmer
2011-02-21 12:31 ` Jeff King
2011-02-22 16:50 ` Will Palmer
2011-02-23 10:04 ` Jeff King [this message]
2011-03-02 15:27 ` Steven Scott
2011-02-21 15:26 ` Steven Scott
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110223100431.GD9222@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=normalperson@yhbt.net \
--cc=wmpalmer@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).