From: Jonathan Nieder <jrnieder@gmail.com>
To: Erik Faye-Lund <kusmabite@gmail.com>
Cc: "Junio C Hamano" <gitster@pobox.com>,
git@vger.kernel.org, "Ævar Arnfjörð" <avarab@gmail.com>
Subject: Re: ab/i18n
Date: Thu, 24 Feb 2011 04:27:12 -0600 [thread overview]
Message-ID: <20110224102712.GC14115@elie> (raw)
In-Reply-To: <AANLkTimn_CmWORwJfWXEiY18QCmXdNZMhCUC9YBMo_kV@mail.gmail.com>
Erik Faye-Lund wrote:
> I like the idea, but perhaps we could auto-generate a Pig Latin
> translation or something instead?
Sorry for the fuss. If I understand correctly, the remaining
issues with the current ab/i18n branch in 'pu' are:
* The series is too long to read in one sitting.
Suggested fix: deal with some arbitrary early subset (35 patches?
I'd even prefer around 20) first.
* Patch 2 (add GETTEXT_POISON) is conceptually complicated since
its arbitrary string is not arbitrary.
Suggested fix: split it into two patches. But I am still not sure
if that's considered acceptable?
* Patch 2 squats on a valuable use_poison() identifier space.
Suggested fix: rename it to gettext_poison().
* Patches 5 (i18n: git-init basic messages) and onward do not
explain "we are marking strings for translation, in
preparation for translating them later" in their commit messages.
Suggested fix: use titles like «i18n: mark some "git init" messages
for translation». Or ignore the problem --- it's not a big deal.
* We haven't run an automated tool to check that this is a no-op
in the -UGETTEXT_POISON case.
Suggested fix: build without debugging symbols and compare the
binaries. Or invent a tool to check patches. Or just use our
eyes, like we always have.
Does that sound like a fair summary? I'd be happy to reroll the
first 30 or so patches following whatever approach is the consensus
for these things to move this forward.
next prev parent reply other threads:[~2011-02-24 10:27 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-23 23:26 What's cooking in git.git (Feb 2011, #05; Wed, 23) Junio C Hamano
2011-02-23 23:48 ` ab/i18n (What's cooking in git.git (Feb 2011, #05; Wed, 23)) Jonathan Nieder
2011-02-24 1:16 ` Junio C Hamano
2011-02-24 2:55 ` Ævar Arnfjörð Bjarmason
2011-02-24 3:14 ` Jonathan Nieder
2011-02-24 10:38 ` Ævar Arnfjörð Bjarmason
2011-02-24 10:45 ` Jonathan Nieder
2011-02-24 11:00 ` Jonathan Nieder
2011-02-25 21:48 ` Ævar Arnfjörð Bjarmason
2011-02-26 5:14 ` Jonathan Nieder
2011-02-24 4:00 ` ab/i18n Jonathan Nieder
2011-02-24 9:56 ` ab/i18n (What's cooking in git.git (Feb 2011, #05; Wed, 23)) Erik Faye-Lund
2011-02-24 10:27 ` Jonathan Nieder [this message]
2011-02-24 19:11 ` ab/i18n Junio C Hamano
2011-02-24 10:40 ` ab/i18n (What's cooking in git.git (Feb 2011, #05; Wed, 23)) Ævar Arnfjörð Bjarmason
2011-02-23 23:52 ` What's cooking in git.git (Feb 2011, #05; Wed, 23) Johan Herland
2011-02-24 0:43 ` Junio C Hamano
2011-02-24 1:04 ` Johan Herland
2011-02-24 0:32 ` Ævar Arnfjörð Bjarmason
2011-02-24 0:57 ` Junio C Hamano
2011-02-24 1:37 ` Ævar Arnfjörð Bjarmason
2011-02-24 1:59 ` Junio C Hamano
2011-02-24 2:07 ` Ævar Arnfjörð Bjarmason
2011-02-24 9:45 ` Erik Faye-Lund
2011-02-24 17:47 ` Ævar Arnfjörð Bjarmason
2011-02-24 22:39 ` Jonathan Nieder
2011-02-25 1:45 ` [msysGit] " Johannes Schindelin
2011-02-25 9:05 ` Kirill Smelkov
2011-02-25 11:11 ` Johannes Schindelin
2011-02-25 19:24 ` Kirill Smelkov
2011-02-25 21:54 ` Johannes Schindelin
2011-02-26 11:07 ` Kirill Smelkov
2011-02-26 19:07 ` Kirill Smelkov
2011-02-26 19:58 ` cross-compiling msys-1.0.dll, was " Johannes Schindelin
2011-03-12 13:18 ` Kirill Smelkov
2011-03-12 15:38 ` Johannes Schindelin
2011-02-27 14:28 ` Johannes Schindelin
2011-03-12 13:16 ` Kirill Smelkov
2011-02-26 10:24 ` Adding Beyond Compare as a merge tool, was: " Sebastian Schuberth
2011-02-26 10:33 ` Junio C Hamano
2011-02-26 10:48 ` Sebastian Schuberth
2011-02-27 5:38 ` Chris Packham
2011-02-27 9:09 ` Junio C Hamano
2011-02-27 10:58 ` Sebastian Schuberth
2011-02-27 10:57 ` Sebastian Schuberth
2011-02-27 11:15 ` Sebastian Schuberth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110224102712.GC14115@elie \
--to=jrnieder@gmail.com \
--cc=avarab@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=kusmabite@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).