From: Jeff King <peff@peff.net>
To: Christian Couder <christian.couder@gmail.com>
Cc: Jonathan Nieder <jrnieder@gmail.com>,
Nguyen Thai Ngoc Duy <pclouds@gmail.com>,
git@vger.kernel.org
Subject: Re: [PATCH 2/8] strbuf: add strbuf_addv
Date: Thu, 24 Feb 2011 10:07:36 -0500 [thread overview]
Message-ID: <20110224150736.GA24346@sigill.intra.peff.net> (raw)
In-Reply-To: <AANLkTi=cBkH5=fmH-k=Sid_4Pwzoa9A4T9z8dcMAjirL@mail.gmail.com>
On Thu, Feb 24, 2011 at 04:05:13PM +0100, Christian Couder wrote:
> > + len = vsnprintf(sb->buf + sb->len, sb->alloc - sb->len, fmt, cp);
> > + va_end(cp);
> > if (len < 0)
> > - die("your vsnprintf is broken");
> > + die("BUG: your vsnprintf is broken (returned -1)");
>
> Minor nit: why not:
>
> + die("BUG: your vsnprintf is broken (returned %d)", len);
No reason. I'll switch to yours in my re-roll.
-Peff
next prev parent reply other threads:[~2011-02-24 15:07 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-24 14:23 [PATCH/RFC 0/8] refactor trace code Jeff King
2011-02-24 14:26 ` [RFC/PATCH 1/8] compat: provide a fallback va_copy definition Jeff King
2011-02-24 15:57 ` Erik Faye-Lund
2011-03-08 8:33 ` [PATCH jk/strbuf-vaddf] compat: fall back on __va_copy if available Jonathan Nieder
2011-03-08 20:09 ` Junio C Hamano
2011-03-08 20:59 ` Jonathan Nieder
2011-02-24 20:33 ` [RFC/PATCH 1/8] compat: provide a fallback va_copy definition Jonathan Nieder
2011-02-24 14:27 ` [PATCH 2/8] strbuf: add strbuf_addv Jeff King
2011-02-24 15:05 ` Christian Couder
2011-02-24 15:07 ` Jeff King [this message]
2011-02-24 20:51 ` Jonathan Nieder
2011-02-24 14:28 ` [PATCH 3/8] trace: add trace_vprintf Jeff King
2011-02-24 21:08 ` Jonathan Nieder
2011-02-24 14:28 ` [PATCH 4/8] trace: refactor to support multiple env variables Jeff King
2011-02-24 18:25 ` Junio C Hamano
2011-02-24 19:02 ` Jeff King
2011-02-24 19:44 ` Junio C Hamano
2011-02-24 19:48 ` Jeff King
2011-02-24 20:50 ` Junio C Hamano
2011-02-24 21:23 ` Jonathan Nieder
2011-02-24 14:28 ` [PATCH 5/8] trace: factor out "do we want to trace" logic Jeff King
2011-02-24 15:07 ` Christian Couder
2011-02-24 14:29 ` [PATCH 6/8] trace: add trace_strbuf Jeff King
2011-02-24 14:30 ` [PATCH 7/8] add packet tracing debug code Jeff King
2011-02-24 21:44 ` Jonathan Nieder
2011-02-24 14:30 ` [PATCH 8/8] trace: give repo_setup trace its own key Jeff King
2011-02-24 15:59 ` Andreas Ericsson
2011-02-24 16:05 ` Jeff King
2011-02-24 20:01 ` Christian Couder
2011-02-24 21:49 ` Jonathan Nieder
2011-02-25 6:38 ` Nguyen Thai Ngoc Duy
2011-02-26 8:34 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110224150736.GA24346@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=christian.couder@gmail.com \
--cc=git@vger.kernel.org \
--cc=jrnieder@gmail.com \
--cc=pclouds@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).