git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Shawn O. Pearce" <spearce@spearce.org>
To: Jeff King <peff@peff.net>
Cc: Sverre Rabbelier <srabbelier@gmail.com>,
	Junio C Hamano <gitster@pobox.com>,
	git@vger.kernel.org
Subject: Re: [PATCH 0/5] Using index-pack in place of verify-pack
Date: Mon, 28 Feb 2011 09:25:32 -0800	[thread overview]
Message-ID: <20110228172455.GA17278@spearce.org> (raw)
In-Reply-To: <20110228165827.GB24915@sigill.intra.peff.net>

Jeff King <peff@peff.net> wrote:
>   $ cd linux-2.6
> 
>   $ time git verify-pack \
>       .git/objects/pack/pack-36c50f6082df404c26a699f2702946e0cce6208f.idx
>   real    2m37.338s
>   user    2m35.874s
>   sys     0m1.348s
> 
>   $ time git index-pack --verify \
>       .git/objects/pack/pack-36c50f6082df404c26a699f2702946e0cce6208f.pack
>   real    1m37.208s
>   user    1m36.106s
>   sys     0m1.048s

Not the improvement I had hoped. Your verify-pack ran much more
quickly than the fsck I was seeing that led me to suggest this to
Junio a few weeks ago. But saving a minute is still pretty good.

That index-pack run is basically what we get during clone, so
I don't really expect to improve on that. (However I have been
contemplating that the locality within the pack isn't optimal and
we can do better placement.)

-- 
Shawn.

  parent reply	other threads:[~2011-02-28 17:25 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-02-28  9:49 [PATCH 0/5] Using index-pack in place of verify-pack Junio C Hamano
2011-02-28  9:49 ` [PATCH 1/5] index-pack: group the delta-base array entries also by type Junio C Hamano
2011-02-28  9:49 ` [PATCH 2/5] write_idx_file: introduce a struct to hold idx customization options Junio C Hamano
2011-02-28  9:49 ` [PATCH 3/5] index-pack: --verify Junio C Hamano
2011-02-28 17:48   ` Shawn O. Pearce
2011-02-28 18:54     ` Junio C Hamano
2011-02-28  9:49 ` [PATCH 4/5] write_idx_file: need_large_offset() helper function Junio C Hamano
2011-02-28  9:49 ` [PATCH 5/5] index-pack --verify: read anomalous offsets from v2 idx file Junio C Hamano
2011-02-28 13:07 ` [PATCH 0/5] Using index-pack in place of verify-pack Sverre Rabbelier
2011-02-28 16:16   ` Junio C Hamano
2011-02-28 16:46     ` Sverre Rabbelier
2011-02-28 16:58       ` Jeff King
2011-02-28 17:01         ` Sverre Rabbelier
2011-02-28 17:25         ` Shawn O. Pearce [this message]
2011-02-28 19:50         ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110228172455.GA17278@spearce.org \
    --to=spearce@spearce.org \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=peff@peff.net \
    --cc=srabbelier@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).