From: Jonathan Nieder <jrnieder@gmail.com>
To: git@vger.kernel.org
Cc: Paul Mackerras <paulus@samba.org>,
Pat Thoyts <patthoyts@users.sourceforge.net>,
Felipe Sateler <fsateler@debian.org>
Subject: Re: gitk: cannot handle tags with a % in them
Date: Mon, 28 Feb 2011 19:38:41 -0600 [thread overview]
Message-ID: <20110301013841.GC5597@elie> (raw)
In-Reply-To: <20110227224024.3751.96676.reportbug@pcfelipe.sateler>
Hi,
Felipe Sateler wrote[1]:
> Gitk chokes on tags containing a % character.
Reproduced as follows:
git tag a%b
gitk
and then clicking on the "| a%b >" symbol.
Result:
can't read "tagids(foo1ar)": no such element in array
can't read "tagids(foo1ar)": no such element in array
while executing
"set text "[mc "Tag"]: $tag\n[mc "Id"]: $tagids($tag)""
(procedure "showtag" line 19)
invoked from within
"showtag foo1ar 1"
(command bound to event)
It seems that a tag containing a percent sign works okay in
an expression like $tagids($tag), but not in a quoted expression
like "$tagids($tag)".
Hints?
Thanks for gitk, of course. :)
Jonathan
[1] http://bugs.debian.org/615645
next parent reply other threads:[~2011-03-01 1:39 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20110227224024.3751.96676.reportbug@pcfelipe.sateler>
2011-03-01 1:38 ` Jonathan Nieder [this message]
2011-03-01 23:50 ` [PATCH] gitk: ensure quoted tag names in event bindings Pat Thoyts
2011-03-02 5:47 ` Jonathan Nieder
2011-03-09 10:05 ` Paul Mackerras
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110301013841.GC5597@elie \
--to=jrnieder@gmail.com \
--cc=fsateler@debian.org \
--cc=git@vger.kernel.org \
--cc=patthoyts@users.sourceforge.net \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).