From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org, kernel@pengutronix.de
Subject: Re: [PATCH] get_remote_url(): use the same data source as ls-remote to get remote urls
Date: Tue, 1 Mar 2011 09:41:10 +0100 [thread overview]
Message-ID: <20110301084110.GT22310@pengutronix.de> (raw)
In-Reply-To: <7v4o7nhgr1.fsf@alter.siamese.dyndns.org>
On Mon, Feb 28, 2011 at 03:38:26PM -0800, Junio C Hamano wrote:
> Uwe Kleine-König <u.kleine-koenig@pengutronix.de> writes:
>
> > with this patch git-request-pull.sh (== the only in-tree user of
> > git-parse-remote.sh:get_remote_url()) could directly use
> >
> > git ls-remote --get-url
> >
> > . I guess you wouldn't want to remove git-parse-remote.sh:get_remote_url()
> > though?!
>
> If nobody uses it, why not? I was actually hoping for the day that nobody
> uses any of the defined function so taht we can remove that whole file.
Ok for me. Probably I'm a bit conservative here because I usually work
on the kernel and people are picky here to remove interfaces.
I can followup with a patch.
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | http://www.pengutronix.de/ |
next prev parent reply other threads:[~2011-03-01 8:41 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-14 9:06 bug: request-pull broken when remote name contains a slash Uwe Kleine-König
2011-01-14 11:36 ` [PATCH] fix git-parse-remote.sh for remotes that contain slashes Stefan Naewe
2011-01-14 19:55 ` Junio C Hamano
2011-02-28 9:36 ` [PATCH] get_remote_url(): use the same data source as ls-remote to get remote urls Uwe Kleine-König
2011-02-28 23:38 ` Junio C Hamano
2011-03-01 8:41 ` Uwe Kleine-König [this message]
2011-03-01 9:21 ` [PATCH 1/2] " Uwe Kleine-König
2011-03-01 9:21 ` [PATCH 2/2] git-request-pull: open-code the only invocation of get_remote_url Uwe Kleine-König
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110301084110.GT22310@pengutronix.de \
--to=u.kleine-koenig@pengutronix.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=kernel@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).