git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jonathan Nieder <jrnieder@gmail.com>
To: Pat Thoyts <patthoyts@users.sourceforge.net>
Cc: git@vger.kernel.org, Paul Mackerras <paulus@samba.org>,
	Felipe Sateler <fsateler@debian.org>
Subject: Re: [PATCH] gitk: ensure quoted tag names in event bindings
Date: Tue, 1 Mar 2011 23:47:05 -0600	[thread overview]
Message-ID: <20110302054629.GB27567@elie> (raw)
In-Reply-To: <87tyfmqu1x.fsf_-_@fox.patthoyts.tk>

Pat Thoyts wrote:

> Tag names that contain a % character require quoting when used in event
> bindings or the name may be mis-recognised for percent substitution in
> the event script.
> 
> Reported-by: Jonathan Nieder <jrnieder@gmail.com>
> Signed-off-by: Pat Thoyts <patthoyts@users.sourceforge.net>
[...]
> 
>  gitk |    7 ++++---
>  1 files changed, 4 insertions(+), 3 deletions(-)

Thanks, makes sense (and seems to work).

  reply	other threads:[~2011-03-02  5:47 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20110227224024.3751.96676.reportbug@pcfelipe.sateler>
2011-03-01  1:38 ` gitk: cannot handle tags with a % in them Jonathan Nieder
2011-03-01 23:50   ` [PATCH] gitk: ensure quoted tag names in event bindings Pat Thoyts
2011-03-02  5:47     ` Jonathan Nieder [this message]
2011-03-09 10:05     ` Paul Mackerras

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110302054629.GB27567@elie \
    --to=jrnieder@gmail.com \
    --cc=fsateler@debian.org \
    --cc=git@vger.kernel.org \
    --cc=patthoyts@users.sourceforge.net \
    --cc=paulus@samba.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).