From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: Jakub Narebski <jnareb@gmail.com>
Cc: "J.H." <warthog9@kernel.org>,
Jonathan Nieder <jrnieder@gmail.com>,
git@vger.kernel.org, admin@repo.or.cz
Subject: Re: gitweb: cloud tags feature produces malformed XML for errors
Date: Thu, 3 Mar 2011 09:19:04 +0100 [thread overview]
Message-ID: <20110303081904.GM22310@pengutronix.de> (raw)
In-Reply-To: <201103030142.17258.jnareb@gmail.com>
Hello Jakub,
On Thu, Mar 03, 2011 at 01:42:15AM +0100, Jakub Narebski wrote:
> On Wed, 2 Mar 2011, Uwe Kleine-König wrote:
> > On Wed, Mar 02, 2011 at 10:18:44PM +0100, Jakub Narebski wrote:
>
> > > What is most important that makes this feature to be considered for
> > > removal (or rehauling) is that only half of this feature is implemented
> > > in gitweb: the displaying part. There is half-attempt of providing
> > > some web interface for managing tags... which needs external script with
> > > strict coupling, doesn't offer any access control as far as I know, do
> > > not allow deleting tags, etc.
> >
> > For a small set of repositories the need to hand-edit the tags is OK
> > IMHO. That's what I intended to do.
>
> So what would you like to see?
>
> 1. Hardening parsing of ctags files, so that gitweb does not crash on
> malformed entries, but e.g. just ignores them.
>
> 2. Generating tag cloud upfront, before sending any output to browser,
> to catch error better (and perhaps separate CSS for HTML::TagCloud).
>
> 3. Describe format of ctags files, either in comments in code, or in
> gitweb/README.
>
> 4. Either:
>
> A. Remove editing ctags from gitweb, or
> B. Add some simple generation of ctags file to gitweb
>
yes :-) (1-3, 4a) I wouldn't mind 4b, but it should be possible to
disable the possibility to publically edit tags via gitweb.
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | http://www.pengutronix.de/ |
next prev parent reply other threads:[~2011-03-03 8:20 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20110301190229.11297.17767.reportbug@cassiopeia.kleinek>
2011-03-01 22:21 ` gitweb: cloud tags feature produces malformed XML for errors Jonathan Nieder
2011-03-02 0:05 ` Jakub Narebski
2011-03-02 8:24 ` Jakub Narebski
2011-03-02 8:45 ` Uwe Kleine-König
2011-03-02 1:06 ` J.H.
2011-03-02 21:18 ` Jakub Narebski
2011-03-02 21:55 ` Uwe Kleine-König
2011-03-03 0:42 ` Jakub Narebski
2011-03-03 8:19 ` Uwe Kleine-König [this message]
2011-03-07 18:00 ` [RFC/PATCH] gitweb: Change the way "content tags" ('ctags') are handled Jakub Narebski
2011-03-09 14:04 ` [PATCH 2/1] gitweb: Mark matched 'ctag' / contents tag (?by_tag=foo) Jakub Narebski
2011-03-09 14:09 ` Petr Baudis
2011-06-09 7:08 ` [PATCH] gitweb: do misparse nonnumeric content tag files that contain a digit Jonathan Nieder
2011-06-09 7:11 ` Jonathan Nieder
2011-03-03 11:58 ` gitweb: cloud tags feature produces malformed XML for errors Petr Baudis
2011-03-03 13:29 ` Jakub Narebski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110303081904.GM22310@pengutronix.de \
--to=u.kleine-koenig@pengutronix.de \
--cc=admin@repo.or.cz \
--cc=git@vger.kernel.org \
--cc=jnareb@gmail.com \
--cc=jrnieder@gmail.com \
--cc=warthog9@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).