From: Jakub Narebski <jnareb@gmail.com>
To: Petr Baudis <pasky@suse.cz>
Cc: "J.H." <warthog9@kernel.org>,
"Jonathan Nieder" <jrnieder@gmail.com>,
git@vger.kernel.org,
"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
admin@repo.or.cz
Subject: Re: gitweb: cloud tags feature produces malformed XML for errors
Date: Thu, 3 Mar 2011 14:29:29 +0100 [thread overview]
Message-ID: <201103031429.32657.jnareb@gmail.com> (raw)
In-Reply-To: <20110303115856.GH24584@machine.or.cz>
On Thu, 3 March 2011, Petr Baudis wrote:
> On Wed, Mar 02, 2011 at 10:18:44PM +0100, Jakub Narebski wrote:
> > Well, neither does README.html follow the repository when it is cloned,
> > and usually neither does description ('description' file is generated by
> > git default template, and description file overrides `gitweb.description'
> > config variable).
> >
> > Documentation always can be added, either as comments for the 'ctags'
> > feature, or in gitweb/README (or, in the future, in gitweb manpage).
> >
> >
> > What is most important that makes this feature to be considered for
> > removal (or rehauling) is that only half of this feature is implemented
> > in gitweb: the displaying part. There is half-attempt of providing
> > some web interface for managing tags... which needs external script with
> > strict coupling, doesn't offer any access control as far as I know, do
> > not allow deleting tags, etc.
>
> Well, but your argument above also applies here - gitweb does not allow
> users to modify README.html or desrciption either. Who knows where ctags
> may come from, they might even be autogenerated based on something.
> I admit that the code could be a bit more resilient to invalid contents
> of the files, but I do not see that as a major problem either (it is
> possible to confuse gitweb by putting invalid stuff into other
> repository files too).
Well, if not the whole 'ctags' / folksonomy feature, then perhaps (as
proposed in other subthread of this discussion, and what Uwe agreed upon)
to remove "write" support for content tags.
Current solution with gitweb providing interface, and third-party script
providing implementation for creating tags, with unspecified API given by
gitweb, and no way to edit / delete tags from web interface, seems
half-baked at best.
BTW. if I remember correctly [failed] GSoC 2010 project was among others
to add ability to edit description and README.html from gitweb; is there
any code about this in Pavan repository?
--
Jakub Narebski
Poland
prev parent reply other threads:[~2011-03-03 13:29 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20110301190229.11297.17767.reportbug@cassiopeia.kleinek>
2011-03-01 22:21 ` gitweb: cloud tags feature produces malformed XML for errors Jonathan Nieder
2011-03-02 0:05 ` Jakub Narebski
2011-03-02 8:24 ` Jakub Narebski
2011-03-02 8:45 ` Uwe Kleine-König
2011-03-02 1:06 ` J.H.
2011-03-02 21:18 ` Jakub Narebski
2011-03-02 21:55 ` Uwe Kleine-König
2011-03-03 0:42 ` Jakub Narebski
2011-03-03 8:19 ` Uwe Kleine-König
2011-03-07 18:00 ` [RFC/PATCH] gitweb: Change the way "content tags" ('ctags') are handled Jakub Narebski
2011-03-09 14:04 ` [PATCH 2/1] gitweb: Mark matched 'ctag' / contents tag (?by_tag=foo) Jakub Narebski
2011-03-09 14:09 ` Petr Baudis
2011-06-09 7:08 ` [PATCH] gitweb: do misparse nonnumeric content tag files that contain a digit Jonathan Nieder
2011-06-09 7:11 ` Jonathan Nieder
2011-03-03 11:58 ` gitweb: cloud tags feature produces malformed XML for errors Petr Baudis
2011-03-03 13:29 ` Jakub Narebski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201103031429.32657.jnareb@gmail.com \
--to=jnareb@gmail.com \
--cc=admin@repo.or.cz \
--cc=git@vger.kernel.org \
--cc=jrnieder@gmail.com \
--cc=pasky@suse.cz \
--cc=u.kleine-koenig@pengutronix.de \
--cc=warthog9@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).