git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jeff King <peff@peff.net>
To: Dietmar Winkler <dietmarw@gmx.de>
Cc: git@vger.kernel.org
Subject: Re: [Bug] %[a|c]d placeholder does not respect --date= option in combination with git archive
Date: Thu, 3 Mar 2011 10:10:19 -0500	[thread overview]
Message-ID: <20110303151019.GC1074@sigill.intra.peff.net> (raw)
In-Reply-To: <4D6F5FA8.5030105@gmx.de>

On Thu, Mar 03, 2011 at 10:30:16AM +0100, Dietmar Winkler wrote:

> In my file I have the place holder $Format:%ad$ and in .git/config the
> setting log.date = short is present.
> [...]
> Now if I run on the same repo
> 	git archive --format=zip HEAD -o out.zip
> and check the place holder in the exported zip file it is actually
> replaced with:
> 
> Thu, 3 Mar 2011 10:06:43 +0100
> 
> and not
> 
> 2011-03-03

I am not sure that this is a bug. The log.date parameter is about the
log command, not necessarily other format substitutions. If it were any
other date format, I would say the right answer is that you should be
using one of the format-specific date specifiers. But annoyingly, there
is no such specifier for "short". Which means there is no way to
actually get the output that you want.

I remember at some point discussing extending the specifier syntax to
allow things like "%(ad,date=short)", but it was never implemented. I
think that would be the cleanest way to do what you want.

The second cleanest would be adding an archive.date variable. Which is
much simpler, obviously. But I think making "log.date" start applying to
archive substitutions is going to surprise some people and possibly
break their setups.

-Peff

  reply	other threads:[~2011-03-03 15:10 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-03-03  9:30 [Bug] %[a|c]d placeholder does not respect --date= option in combination with git archive Dietmar Winkler
2011-03-03 15:10 ` Jeff King [this message]
2011-03-04 10:10   ` Dietmar Winkler
2011-03-05 19:50     ` Jeff King
2011-03-05 19:51       ` [PATCH 1/2] pretty.c: give format_person_part the whole placeholder Jeff King
2011-03-05 20:00       ` [PATCH 2/2] pretty.c: allow date formats in user format strings Jeff King
     [not found]         ` <AANLkTinH8zwX2sbd5bpk=x4R3zOAg3Dc92Fbspfdv03T@mail.gmail.com>
2011-03-06 21:54           ` Fwd: " Will Palmer
2011-03-07 16:17             ` Jeff King
2011-03-07 17:28               ` Will Palmer
2011-03-07 18:50                 ` Will Palmer
2011-03-07 19:26                   ` Jeff King
2011-03-08  8:29                     ` Will Palmer
2011-03-09 21:06               ` Junio C Hamano
2011-03-10 22:31                 ` Jeff King
2011-03-11  8:33                   ` Dietmar Winkler

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110303151019.GC1074@sigill.intra.peff.net \
    --to=peff@peff.net \
    --cc=dietmarw@gmx.de \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).