From: Nicolas Kaiser <nikai@nikai.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org
Subject: [PATCH] transport-helper.c: fix check for size_t < 0
Date: Fri, 4 Mar 2011 20:28:34 +0100 [thread overview]
Message-ID: <20110304202834.2e74d56d@absol.kitzblitz> (raw)
'bytes' is unsigned of type size_t, and can't be negative.
But the assigned write() returns ssize_t, and -1 on error.
For testing < 0, 'bytes' needs to be of a signed type.
Signed-off-by: Nicolas Kaiser <nikai@nikai.net>
---
Testsuite did not regress at my place.
transport-helper.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/transport-helper.c b/transport-helper.c
index 4e4754c..710b6f1 100644
--- a/transport-helper.c
+++ b/transport-helper.c
@@ -973,7 +973,7 @@ static int udt_do_read(struct unidirectional_transfer *t)
*/
static int udt_do_write(struct unidirectional_transfer *t)
{
- size_t bytes;
+ int bytes;
if (t->bufuse == 0)
return 0; /* Nothing to write. */
@@ -989,7 +989,7 @@ static int udt_do_write(struct unidirectional_transfer *t)
if (t->bufuse)
memmove(t->buf, t->buf + bytes, t->bufuse);
transfer_debug("Wrote %i bytes to %s (buffer now at %i)",
- (int)bytes, t->dest_name, (int)t->bufuse);
+ bytes, t->dest_name, (int)t->bufuse);
}
return 0;
}
--
1.7.3.4
next reply other threads:[~2011-03-04 20:06 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-04 19:28 Nicolas Kaiser [this message]
2011-03-04 20:20 ` [PATCH] transport-helper.c: fix check for size_t < 0 Piotr Krukowiecki
2011-03-04 23:16 ` [PATCH] transport-helper.c: fix check for size_t < 0 v2 Nicolas Kaiser
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110304202834.2e74d56d@absol.kitzblitz \
--to=nikai@nikai.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).