From: Nicolas Kaiser <nikai@nikai.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org
Subject: [PATCH] builtin/apply.c: remove impossible check
Date: Fri, 4 Mar 2011 20:43:58 +0100 [thread overview]
Message-ID: <20110304204358.3f5618cf@absol.kitzblitz> (raw)
'n1' and 'n2' are unsigned of type size_t, and can never
be negative.
Signed-off-by: Nicolas Kaiser <nikai@nikai.net>
---
Testsuite did not regress at my place.
builtin/apply.c | 3 ---
1 files changed, 0 insertions(+), 3 deletions(-)
diff --git a/builtin/apply.c b/builtin/apply.c
index 14951da..6069377 100644
--- a/builtin/apply.c
+++ b/builtin/apply.c
@@ -248,9 +248,6 @@ static int fuzzy_matchlines(const char *s1, size_t n1,
const char *last2 = s2 + n2 - 1;
int result = 0;
- if (n1 < 0 || n2 < 0)
- return 0;
-
/* ignore line endings */
while ((*last1 == '\r') || (*last1 == '\n'))
last1--;
--
1.7.3.4
reply other threads:[~2011-03-04 19:45 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110304204358.3f5618cf@absol.kitzblitz \
--to=nikai@nikai.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).