From: Jeff King <peff@peff.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: Adam Monsen <haircut@gmail.com>,
git@vger.kernel.org, Jakub Narebski <jnareb@gmail.com>
Subject: Re: [PATCH 1/2] documentation fix: git log -p does not imply -c.
Date: Mon, 7 Mar 2011 10:47:12 -0500 [thread overview]
Message-ID: <20110307154712.GA11934@sigill.intra.peff.net> (raw)
In-Reply-To: <7vbp1n4vhv.fsf@alter.siamese.dyndns.org>
On Sun, Mar 06, 2011 at 04:36:28PM -0800, Junio C Hamano wrote:
> Adam Monsen <haircut@gmail.com> writes:
>
> > Relates to the thread with subject "frustrated forensics: hard to find
> > diff that undid a fix" on the git mailing list.
> >
> > http://thread.gmane.org/gmane.comp.version-control.git/168481
> >
> > I don't wish for anyone to repeat my bungled forensics episode.
>
> But this patch is wrong, isn't it?
>
> The --cc format _is_ the default, not -c format.
Hmm. "git show" seems to show --cc, but "git log -p" does not show
anything. Try:
$ git show 1538f21
$ git log -p -1 1538f21
So the current doc seems to be wrong. Should we be fixing the code and
not the doc?
-Peff
next prev parent reply other threads:[~2011-03-07 15:47 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-05 6:20 frustrated forensics: hard to find diff that undid a fix Adam Monsen
2011-03-05 10:00 ` Jonathan del Strother
2011-03-05 11:33 ` Jakub Narebski
2011-03-05 12:51 ` Jonathan Nieder
2011-03-05 13:48 ` Jeff King
2011-03-05 14:34 ` Adam Monsen
2011-03-05 19:56 ` [PATCH 0/2] improve combined diff documentation Adam Monsen
2011-03-05 19:56 ` [PATCH 1/2] documentation fix: git log -p does not imply -c Adam Monsen
2011-03-07 0:36 ` Junio C Hamano
2011-03-07 15:47 ` Jeff King [this message]
2011-03-07 18:37 ` Junio C Hamano
2011-03-07 19:12 ` Jeff King
2011-03-07 21:57 ` [PATCH v3] Documentation " Adam Monsen
2011-03-08 0:21 ` Junio C Hamano
2011-03-08 0:49 ` [PATCH v4] " Adam Monsen
2011-03-08 19:43 ` Junio C Hamano
2011-03-08 20:46 ` Adam Monsen
2011-03-09 0:58 ` Junio C Hamano
2011-03-09 21:25 ` Adam Monsen
2011-03-09 21:27 ` [PATCH] SubmittingPatches: clean up commit message tips Adam Monsen
2011-03-09 22:20 ` Junio C Hamano
2011-03-08 20:51 ` [PATCH v5] diff format documentation: clarify --cc and -c Adam Monsen
2011-03-08 21:03 ` [PATCH v6] " Adam Monsen
2011-03-08 1:19 ` [PATCH v3] Documentation fix: git log -p does not imply -c Jeff King
2011-03-05 19:56 ` [PATCH 2/2] English grammar fixes for combined diff doc Adam Monsen
2011-03-05 14:29 ` frustrated forensics: hard to find diff that undid a fix Martin von Zweigbergk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110307154712.GA11934@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=haircut@gmail.com \
--cc=jnareb@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).