From: Jeff King <peff@peff.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: Matthieu Moy <Matthieu.Moy@imag.fr>, git@vger.kernel.org
Subject: Re: [PATCH] log: fix --max-count when used together with -S or -G
Date: Thu, 10 Mar 2011 17:39:34 -0500 [thread overview]
Message-ID: <20110310223934.GF15828@sigill.intra.peff.net> (raw)
In-Reply-To: <7vk4g87wvf.fsf@alter.siamese.dyndns.org>
On Wed, Mar 09, 2011 at 02:27:32PM -0800, Junio C Hamano wrote:
> Jeff King <peff@peff.net> writes:
>
> > Hmm. Is this papering over a bigger problem,...
>
> It is not very obvious to me if redefining the semantics of filtering done
> by diff (the current definition is it is purely an output phase thing) is
> necessarily a good thing. I agree that the interaction between the output
> phase filtering and pruning done by the revision walker machinery is a
> fine topic to discuss.
>
> But Matthieu's patch is not papering over anything but is a real fix
> within the context of the current architecture.
I consider the current state to be "buggy but we live with it" and not
an architectural decision. But that is simply a matter of perspective. :)
Certainly Matthieu's patch fixes a real problem, and it does not make it
any harder to address the other problems in the future, so I think there
is no reason not to apply it.
-Peff
prev parent reply other threads:[~2011-03-10 22:39 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-06 21:37 BUG? git log -Sfoo --max-count=N Óscar Fuentes
2011-03-07 12:46 ` [RFC/PATCH] " Matthieu Moy
2011-03-08 19:22 ` Junio C Hamano
2011-03-09 20:52 ` [PATCH] log: fix --max-count when used together with -S or -G Matthieu Moy
2011-03-09 21:38 ` Jeff King
2011-03-09 21:49 ` Matthieu Moy
2011-03-09 22:27 ` Junio C Hamano
2011-03-10 22:39 ` Jeff King [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110310223934.GF15828@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=Matthieu.Moy@imag.fr \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).