From: Jeff King <peff@peff.net>
To: Jonathan Nieder <jrnieder@gmail.com>
Cc: git@vger.kernel.org, Junio C Hamano <gitster@pobox.com>,
Petr Onderka <gsvick@gmail.com>
Subject: Re: [PATCH 2/3] tests: suppress global and system gitattributes
Date: Tue, 15 Mar 2011 03:16:25 -0400 [thread overview]
Message-ID: <20110315071625.GA11754@sigill.intra.peff.net> (raw)
In-Reply-To: <20110315065643.GB29530@elie>
On Tue, Mar 15, 2011 at 01:56:43AM -0500, Jonathan Nieder wrote:
> Set GIT_ATTR_NOGLOBAL and GIT_ATTR_NOSYSTEM in test-lib to make
> tests more reliable in two ways:
>
> - an invalid GIT_ATTR_NOGLOBAL or GIT_ATTR_NOSYSTEM setting
> should not cause tests to fail with
>
> fatal: bad config value for 'GIT_ATTR_NOGLOBAL'
>
> - /etc/gitattributes should not change the outcome of tests.
We already munge $HOME, as you note in 1/3, I don't know that there is
much point in setting GIT_ATTR_NOGLOBAL. The alternative would be to
drop your 1/3 and unset GIT_ATTR_NOGLOBAL in test-lib.sh.
I don't care much either way. Having it set prevents others tests from
accidentally triggering global attributes (since we have the odd case of
$HOME and the repo in the same directory). But IIRC, they'd have to set
core.attributesfile anyway, so that is not likely to happen.
And what you're doing at least matches what GIT_CONFIG_* does (I think
GIT_CONFIG_NOGLOBAL is also redundant in the tests at this point).
So I'm fine with either strategy. But definitely it should be protected,
so thanks for looking into it.
-Peff
next prev parent reply other threads:[~2011-03-15 7:17 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-15 6:49 [PATCH 0/3] tests: unsetting variables that influence the outcome Jonathan Nieder
2011-03-15 6:56 ` [PATCH 1/3] tests: protect against GIT_ATTR_NOGLOBAL from environment Jonathan Nieder
2011-03-15 6:56 ` [PATCH 2/3] tests: suppress global and system gitattributes Jonathan Nieder
2011-03-15 7:16 ` Jeff King [this message]
2011-03-15 9:02 ` [PATCH 1-2/3 v2 0/3] " Jonathan Nieder
2011-03-15 9:04 ` [PATCH 1/3] gitattributes: drop support for GIT_ATTR_NOGLOBAL Jonathan Nieder
2011-03-15 9:04 ` [PATCH 2/3] config: drop support for GIT_CONFIG_NOGLOBAL Jonathan Nieder
2011-03-15 9:05 ` [PATCH 3/3] tests: suppress system gitattributes Jonathan Nieder
2011-03-15 7:04 ` [PATCH 3/3] tests: scrub environment of GIT_* variables Jonathan Nieder
2011-03-15 7:37 ` Jeff King
2011-03-15 10:08 ` [RFC/PATCH 0/2] tests: stop hard-coding the list of GIT_* vars to scrub Jonathan Nieder
2011-03-15 10:09 ` [PATCH 1/2] tests: stop worrying about obsolete environment variables Jonathan Nieder
2011-03-15 10:10 ` [RFC/PATCH 2/2] tests: scrub environment of GIT_* variables Jonathan Nieder
2011-03-15 17:20 ` Junio C Hamano
2011-03-15 20:01 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110315071625.GA11754@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=gsvick@gmail.com \
--cc=jrnieder@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).