From: Jonathan Nieder <jrnieder@gmail.com>
To: Johannes Sixt <j.sixt@viscovery.net>
Cc: Junio C Hamano <gitster@pobox.com>,
git@vger.kernel.org, Michael Wookey <michaelwookey@gmail.com>,
Markus Heidelberg <markus.heidelberg@web.de>
Subject: Re: [PATCH] run-command: prettify -D_FORTIFY_SOURCE workaround
Date: Wed, 16 Mar 2011 04:25:26 -0500 [thread overview]
Message-ID: <20110316092526.GA7886@elie> (raw)
In-Reply-To: <4D80801A.1000208@viscovery.net>
Johannes Sixt wrote:
> And what about compilers that warn:
>
> ';' : empty controlled statement found; is this the intent?
>
> That's from MSVC. Perhaps:
>
> if (write(...))
> (void)0; /* we know we are ignoring the error, mr gcc! */
Mm, thanks for pointing it out.
Your suggestion is part of a bigger change that imho should go in a
separate patch:
$ git grep -F -e ' ; /*' origin/master | wc -l
65
I would prefer to see such a patch do
if (write(...)) {
/* ... explanation goes here ... */
}
or something like
#define do_nothing() do { /* nothing */ } while (0)
if (write(...))
do_nothing(); /* ... explanation ... */
but that is a small detail.
prev parent reply other threads:[~2011-03-16 9:25 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-29 22:38 [PATCH] run-command.c: fix build warnings on Ubuntu Michael Wookey
2010-01-30 16:43 ` Markus Heidelberg
2011-03-16 3:51 ` [PATCH] run-command: prettify -D_FORTIFY_SOURCE workaround Jonathan Nieder
2011-03-16 5:37 ` Junio C Hamano
2011-03-16 7:32 ` [PATCH v2] " Jonathan Nieder
2011-03-17 22:34 ` Junio C Hamano
2011-03-16 9:17 ` [PATCH] " Johannes Sixt
2011-03-16 9:25 ` Jonathan Nieder [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110316092526.GA7886@elie \
--to=jrnieder@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=j.sixt@viscovery.net \
--cc=markus.heidelberg@web.de \
--cc=michaelwookey@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).