git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jonathan Nieder <jrnieder@gmail.com>
To: "Carlos Martín Nieto" <cmn@elego.de>
Cc: git@vger.kernel.org, Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH] valgrind: ignore SSE-based strlen invalid reads
Date: Wed, 16 Mar 2011 05:52:14 -0500	[thread overview]
Message-ID: <20110316105214.GB8277@elie> (raw)
In-Reply-To: <1300272453-25891-1-git-send-email-cmn@elego.de>

Carlos Martín Nieto wrote:

> The GNU C Library (glibc) uses SSE instructions to make strlen (among
> others) faster, loading 4 bytes at a time and reading past the end of
> the allocated memory. This read is safe and when the strlen function
> is inlined, it is (obviously) not replaced by valgrind, which reports
> a false-possitive.

This still makes no sense to me.  How is it possible to inline a
function from glibc?  When I look in /usr/include/string.h, I see

extern size_t strlen (__const char *__s)
     __THROW __attribute_pure__ __nonnull ((1));

> Tell valgrind to ignore this particular error, as the read is, in
> fact, safe.

I'm happy to see a workaround.  I would be even happier if it came
with documentation about which versions of valgrind need it.

Thanks again.
Jonathan

  reply	other threads:[~2011-03-16 10:52 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-03-16  9:31 [PATCH] valgrind: ignore SSE-based strlen invalid reads Carlos Martín Nieto
2011-03-16  9:56 ` Jonathan Nieder
2011-03-16 10:41   ` Carlos Martín Nieto
2011-03-16 10:47   ` Carlos Martín Nieto
2011-03-16 10:52     ` Jonathan Nieder [this message]
2011-03-16 11:10       ` Carlos Martín Nieto
2011-03-16 11:25         ` Jonathan Nieder
2011-03-16 11:46           ` Carlos Martín Nieto
2011-03-16 20:18             ` Junio C Hamano
2011-03-16 20:44               ` Carlos Martín Nieto
2011-03-16 22:43         ` Andreas Schwab

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110316105214.GB8277@elie \
    --to=jrnieder@gmail.com \
    --cc=cmn@elego.de \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).