git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jeff King <peff@peff.net>
To: Michael J Gruber <git@drmicha.warpmail.net>
Cc: Junio C Hamano <gitster@pobox.com>,
	Ian Ward Comfort <icomfort@stanford.edu>,
	git@vger.kernel.org
Subject: Re: [PATCH v2] commit, status: #comment diff output in verbose mode
Date: Thu, 17 Mar 2011 15:41:22 -0400	[thread overview]
Message-ID: <20110317194122.GE20508@sigill.intra.peff.net> (raw)
In-Reply-To: <4D81BFDD.7050009@drmicha.warpmail.net>

On Thu, Mar 17, 2011 at 09:01:33AM +0100, Michael J Gruber wrote:

> > Yuck. You may be literally feeding different charsets into a single
> > buffer of the editor. The best you could do is something like:
> > 
> >   au BufNewFile,BufRead COMMIT_EDITMSG set fenc=utf-8
>
> [...]
>
> Though I'm wondering whether we should do something about it in general
> (we assume utf8 commit messages, don't we), at least in doc. Your
> suggestion above does make things safer (so that you don't screw up the
> commit message accidentally) and would make a good patch to vim's
> filetype.vim

Being perfectly content with ASCII for my native language, I am not a
good person to judge. But I wonder how common your situation is. That
is, your files are all in latin1, but you continue to use utf8 for your
commit messages. Perhaps an easier solution would just be to tell git
that you want to make commit messages in latin1?

-Peff

  reply	other threads:[~2011-03-17 19:41 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-03-10 19:59 [PATCH v2] commit, status: #comment diff output in verbose mode Ian Ward Comfort
2011-03-10 22:52 ` Jeff King
2011-03-10 23:57   ` SZEDER Gábor
2011-03-11  0:45   ` Junio C Hamano
2011-03-11  1:23     ` Jeff King
2011-03-11  5:31       ` Jeff King
2011-03-11  8:49         ` Michael J Gruber
2011-03-17  7:37           ` Jeff King
2011-03-17  8:01             ` Michael J Gruber
2011-03-17 19:41               ` Jeff King [this message]
2011-03-13 18:34       ` Piotr Krukowiecki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110317194122.GE20508@sigill.intra.peff.net \
    --to=peff@peff.net \
    --cc=git@drmicha.warpmail.net \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=icomfort@stanford.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).