Re: [PATCH] pretty.c: Make user defined format honor color option

[Jeff King <peff@peff.net>]

On Thu, Mar 17, 2011 at 12:59:52PM +0000, Will Palmer wrote:

> Perhaps --color=auto, specified on the command-line, should behave
> differently to the various color options specified via config. That
> might make both sides happy, as one could always specify --color=auto to
> explicitly tell git to only color if it thinks it should.
> 
> Can anyone else refresh my memory regarding the use-case where
> hand-specified colors really should have an effect even with
> --color=never?

Without doing any digging on the list and just from the top of my head,
I don't think it was ever really an intentional feature that format
should ignore color settings. It simply wasn't bothered with because in
the beginning, the only way to specify a format was on the command line.
Now as we see them used in aliases, it probably makes sense to respect
the color setting. If one wants the current behavior, they can always
use --color=always.

So I think the intent of Thomas' patch is a good change, though I
haven't really looked closely at the patch itself.

-Peff