git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Thomas Rast <trast@student.ethz.ch>
To: Johan Herland <johan@herland.net>
Cc: Hallvard B Furuseth <h.b.furuseth@usit.uio.no>, <git@vger.kernel.org>
Subject: Re: git filter-branch --filter-notes/--post-rewrite?
Date: Fri, 18 Mar 2011 10:53:58 +0100	[thread overview]
Message-ID: <201103181053.58969.trast@student.ethz.ch> (raw)
In-Reply-To: <201103180116.14754.johan@herland.net>

Johan Herland wrote:
> On Thursday 17 March 2011, Hallvard B Furuseth wrote:
> > Is there a git version where filter-branch can copy notes, or with a
> > post-rewrite hook?  I found an old discussion of that on WWW, but
> > nothing seems to have come of that yet.  Currently I remove the 'rm
> > -rf "$tempdir"' in git-filter-branch.sh so the info is available
> > for a separate script.
> 
> No, AFAIK notes copying (or post-rewrite hook) has not yet been implemented 
> in filter-branch. However, it shouldn't be very difficult to add support for 
> this:
> 
> Looking at git-rebase.sh (where it _is_ implemented), it seems to be a 
> matter of feeding "old_sha1 new_sha1" pairs into a "rewritten" file, and 
> then passing that file to the stdin of "git notes copy --for-rewrite=filter-
> branch" (followed by passing the same file to the "post-rewrite" hook).

I had a patch for this back when post-rewrite was invented,

  http://thread.gmane.org/gmane.comp.version-control.git/139919/focus=139917

but Hannes replied that it should grow a real notes filter, and while
I dropped it there, I tend to agree with him.  Feel free to pick it up
again.

-- 
Thomas Rast
trast@{inf,student}.ethz.ch

  reply	other threads:[~2011-03-18  9:54 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-03-17 20:50 git filter-branch --filter-notes/--post-rewrite? Hallvard B Furuseth
2011-03-18  0:16 ` Johan Herland
2011-03-18  9:53   ` Thomas Rast [this message]
2011-03-20 22:55     ` Hallvard B Furuseth
2011-03-21  2:39       ` Johan Herland

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201103181053.58969.trast@student.ethz.ch \
    --to=trast@student.ethz.ch \
    --cc=git@vger.kernel.org \
    --cc=h.b.furuseth@usit.uio.no \
    --cc=johan@herland.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).