From: Jakub Narebski <jnareb@gmail.com>
To: Kevin Cernekee <cernekee@gmail.com>
Cc: Junio C Hamano <gitster@pobox.com>, git@vger.kernel.org
Subject: Re: [PATCH v2 4/3] gitweb: Always call format_date with timezone parameter
Date: Sun, 20 Mar 2011 11:37:17 +0100 [thread overview]
Message-ID: <201103201137.18619.jnareb@gmail.com> (raw)
In-Reply-To: <b599dae39131b90d0970a1ef63e6599b@localhost>
On Sun, 20 Mar 2011, Kevin Cernekee wrote:
> From: Jakub Narebski <jnareb@gmail.com>
>
> Make the timezone parameter mandatory. This ensures that the *_local
> fields are always populated with accurate information.
That is better commit message that what I came with.
> Also, delete an unnecessary call to format_date().
>
> Signed-off-by: Jakub Narebski <jnareb@gmail.com>
> Signed-off-by: Kevin Cernekee <cernekee@gmail.com>
> ---
>
> v2: Fix typos. Remove unnecessary call.
Thanks.
> Remove default "-0000" tz value.
Hmmm... I wonder if default value for timezone might have been intended
to handle case of malformed date, without timezone.
This fragment
my $epoch = shift;
my $tz = shift || "-0000";
is from very beginnings of gitweb... and "v042" is a bit uninformative
as a commit message. 991910a (v042, 2005-08-07).
> Rebase on top of my patch 3/3 (as applying -1/3 then 1/3 would create a
> merge conflict).
You are right, that is better solution.
--
Jakub Narebski
Poland
next prev parent reply other threads:[~2011-03-20 10:37 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-19 20:48 [PATCH v2 1/3] gitweb: rename parse_date() to format_date() Kevin Cernekee
2011-03-19 20:48 ` [PATCH v5 2/3] gitweb: introduce localtime feature Kevin Cernekee
2011-03-19 20:48 ` [PATCH/RFC 3/3] gitweb: change highlighting of "atnight" commits Kevin Cernekee
2011-03-19 22:18 ` [PATCH -1/3] gitweb: Always call parse_date with timezone parameter Jakub Narebski
2011-03-19 22:53 ` [PATCH -1/3 (amend)] " Jakub Narebski
2011-03-19 22:56 ` [PATCH -1/3] " Kevin Cernekee
2011-03-20 0:25 ` Jakub Narebski
2011-03-20 0:27 ` Junio C Hamano
2011-03-20 2:11 ` [PATCH v2 4/3] gitweb: Always call format_date " Kevin Cernekee
2011-03-20 10:37 ` Jakub Narebski [this message]
2011-03-20 11:07 ` Jakub Narebski
2011-03-20 20:47 ` Kevin Cernekee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201103201137.18619.jnareb@gmail.com \
--to=jnareb@gmail.com \
--cc=cernekee@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).