From: Stephen Hemminger <shemminger@vyatta.com>
To: git@vger.kernel.org
Subject: git svn perl issues
Date: Wed, 23 Mar 2011 08:52:37 -0700 [thread overview]
Message-ID: <20110323085237.1a52ab7e@nehalam> (raw)
1. The following needs to be fixed:
$ git svn clone
Use of uninitialized value $_[0] in substitution (s///) at /usr/share/perl/5.10.1/File/Basename.pm line 341.
fileparse(): need a valid pathname at /usr/lib/git-core/git-svn line 403
2. The git-svn perl script does not follow Perl Best Practices.
If you run the perlcritic script on it, all the following warnings/errors
are generated:
$ perlcritic /usr/lib/git-core/git-svn
Code before strictures are enabled at line 2, column 10. See page 429 of PBP. (Severity: 5)
Variable declared in conditional statement at line 18, column 1. Declare variables outside of the condition. (Severity: 5)
Subroutine prototypes used at line 39, column 1. See page 194 of PBP. (Severity: 5)
Stricture disabled at line 65, column 2. See page 429 of PBP. (Severity: 5)
Variable declared in conditional statement at line 287, column 1. Declare variables outside of the condition. (Severity: 5)
Variable declared in conditional statement at line 533, column 2. Declare variables outside of the condition. (Severity: 5)
Bareword file handle opened at line 851, column 3. See pages 202,204 of PBP. (Severity: 5)
Bareword file handle opened at line 1169, column 4. See pages 202,204 of PBP. (Severity: 5)
Variable declared in conditional statement at line 1571, column 3. Declare variables outside of the condition. (Severity: 5)
Stricture disabled at line 1682, column 2. See page 429 of PBP. (Severity: 5)
Don't modify $_ in list functions at line 1815, column 11. See page 114 of PBP. (Severity: 5)
"return" statement with explicit "undef" at line 1891, column 2. See page 199 of PBP. (Severity: 5)
"return" statement with explicit "undef" at line 1969, column 2. See page 199 of PBP. (Severity: 5)
Variable declared in conditional statement at line 1990, column 3. Declare variables outside of the condition. (Severity: 5)
Nested named subroutine at line 2135, column 2. Declaring a named sub inside another named sub does not prevent the inner sub from being global. (Severity: 5)
"return" statement with explicit "undef" at line 2140, column 3. See page 199 of PBP. (Severity: 5)
"return" statement with explicit "undef" at line 2663, column 2. See page 199 of PBP. (Severity: 5)
"return" statement with explicit "undef" at line 2671, column 2. See page 199 of PBP. (Severity: 5)
"return" statement with explicit "undef" at line 2682, column 2. See page 199 of PBP. (Severity: 5)
"return" statement with explicit "undef" at line 2753, column 2. See page 199 of PBP. (Severity: 5)
Nested named subroutine at line 2789, column 2. Declaring a named sub inside another named sub does not prevent the inner sub from being global. (Severity: 5)
"return" statement with explicit "undef" at line 3373, column 3. See page 199 of PBP. (Severity: 5)
"return" statement with explicit "undef" at line 3707, column 2. See page 199 of PBP. (Severity: 5)
"return" statement with explicit "undef" at line 3723, column 3. See page 199 of PBP. (Severity: 5)
Bareword file handle opened at line 3977, column 3. See pages 202,204 of PBP. (Severity: 5)
"return" statement with explicit "undef" at line 4116, column 2. See page 199 of PBP. (Severity: 5)
"return" statement with explicit "undef" at line 4119, column 2. See page 199 of PBP. (Severity: 5)
"return" statement with explicit "undef" at line 4204, column 2. See page 199 of PBP. (Severity: 5)
"return" statement with explicit "undef" at line 4212, column 2. See page 199 of PBP. (Severity: 5)
"return" statement with explicit "undef" at line 4220, column 2. See page 199 of PBP. (Severity: 5)
"return" statement with explicit "undef" at line 4228, column 2. See page 199 of PBP. (Severity: 5)
"return" statement with explicit "undef" at line 4244, column 2. See page 199 of PBP. (Severity: 5)
"return" statement with explicit "undef" at line 4291, column 2. See page 199 of PBP. (Severity: 5)
Nested named subroutine at line 4463, column 2. Declaring a named sub inside another named sub does not prevent the inner sub from being global. (Severity: 5)
Subroutine prototypes used at line 4707, column 1. See page 194 of PBP. (Severity: 5)
Stricture disabled at line 4817, column 2. See page 429 of PBP. (Severity: 5)
Subroutine prototypes used at line 4831, column 1. See page 194 of PBP. (Severity: 5)
Nested named subroutine at line 5160, column 3. Declaring a named sub inside another named sub does not prevent the inner sub from being global. (Severity: 5)
Nested named subroutine at line 5271, column 2. Declaring a named sub inside another named sub does not prevent the inner sub from being global. (Severity: 5)
Use IO::Interactive::is_interactive() instead of -t at line 5477, column 8. See page 218 of PBP. (Severity: 5)
"return" statement with explicit "undef" at line 5823, column 2. See page 199 of PBP. (Severity: 5)
Glob written as <...> at line 5904, column 11. See page 167 of PBP. (Severity: 5)
next reply other threads:[~2011-03-23 15:52 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-23 15:52 Stephen Hemminger [this message]
2011-03-23 21:38 ` git svn perl issues Lasse Makholm
2011-03-23 21:45 ` Stephen Hemminger
2011-03-23 22:19 ` Lasse Makholm
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110323085237.1a52ab7e@nehalam \
--to=shemminger@vyatta.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).