From: Jeff King <peff@peff.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: "Michał Łowicki" <mlowicki@gmail.com>, git@vger.kernel.org
Subject: Re: gsoc - Better git log --follow support
Date: Wed, 23 Mar 2011 14:22:49 -0400 [thread overview]
Message-ID: <20110323182249.GA17490@sigill.intra.peff.net> (raw)
In-Reply-To: <7vk4fpemei.fsf@alter.siamese.dyndns.org>
On Wed, Mar 23, 2011 at 11:12:37AM -0700, Junio C Hamano wrote:
> Jeff King <peff@peff.net> writes:
>
> > Obviously a solution that always provides an exact right answer is
> > preferable to "pretty good results", but we'd have to keep in mind the
> > performance difference.
>
> And that is why the current --follow hack was declared to be good enough
> to give "pretty good results" by its inventor, no?
Absolutely. I just think we can make "pretty good" slightly better with
just a little more effort.
> I still agree with it personally, and if we _were_ to improve it out of
> "hack" status, we should aim to do the right thing (provided if there is a
> "right thing" exists).
Right. The problem is that I'm not sure we want to pay the performance
penalty to take it out of "hack" status. But that doesn't mean we can't
make it as good a hack as possible. :)
Actually, I think the non-hack version of it is not really --follow at
all, but more like Bo's line-level browser. But I think that still
leaves room for a solution like --follow that is perhaps a bit faster
and provides a pretty good answer.
-Peff
next prev parent reply other threads:[~2011-03-23 18:22 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-19 19:24 gsoc - Better git log --follow support Michał Łowicki
2011-03-19 21:57 ` GSoC - Better "git log --follow" support Jakub Narebski
2011-03-21 12:24 ` gsoc - Better git log --follow support Jeff King
2011-03-22 23:23 ` Michał Łowicki
2011-03-23 16:20 ` Jeff King
2011-03-23 16:58 ` Junio C Hamano
2011-03-23 17:06 ` Jeff King
2011-03-23 18:12 ` Junio C Hamano
2011-03-23 18:22 ` Jeff King [this message]
2011-04-13 21:04 ` Michał Łowicki
2011-04-15 4:06 ` Jonathan Nieder
2011-04-15 19:41 ` Michał Łowicki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110323182249.GA17490@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=mlowicki@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).