From: Jeff King <peff@peff.net>
To: Alex Riesen <raa.lkml@gmail.com>
Cc: git@vger.kernel.org, Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH] HOME must be set before calling git-init when creating test repositories
Date: Sat, 26 Mar 2011 14:48:06 -0400 [thread overview]
Message-ID: <20110326184806.GA4488@sigill.intra.peff.net> (raw)
In-Reply-To: <20110326184634.GB13496@blimp.localdomain>
On Sat, Mar 26, 2011 at 07:46:34PM +0100, Alex Riesen wrote:
> diff --git a/t/test-lib.sh b/t/test-lib.sh
> index 7cc9a52..7965b74 100644
> --- a/t/test-lib.sh
> +++ b/t/test-lib.sh
> @@ -984,14 +984,14 @@ rm -fr "$test" || {
> exit 1
> }
>
> +HOME="$TRASH_DIRECTORY"
> +export HOME
> +
> test_create_repo "$test"
> # Use -P to resolve symlinks in our working directory so that the cwd
> # in subprocesses like git equals our $PWD (for pathname comparisons).
> cd -P "$test" || exit 1
>
> -HOME=$(pwd)
> -export HOME
> -
That looks right to me. Thanks.
-Peff
prev parent reply other threads:[~2011-03-26 18:48 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-25 20:05 [PATCH] HOME must be set before calling git-init when creating test repositories Alex Riesen
2011-03-25 20:44 ` [PATCH, fixed] " Alex Riesen
2011-03-25 20:49 ` [PATCH] " Junio C Hamano
2011-03-25 21:01 ` Alex Riesen
2011-03-25 21:30 ` Junio C Hamano
2011-03-25 21:51 ` Alex Riesen
2011-03-25 22:39 ` Junio C Hamano
2011-03-26 10:08 ` Alex Riesen
2011-03-26 14:11 ` Jeff King
2011-03-26 18:21 ` Alex Riesen
2011-03-26 18:31 ` Jeff King
2011-03-26 18:42 ` Alex Riesen
2011-03-26 18:46 ` Alex Riesen
2011-03-26 18:48 ` Jeff King [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110326184806.GA4488@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=raa.lkml@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).