From: Jonathan Nieder <jrnieder@gmail.com>
To: Jens Lehmann <Jens.Lehmann@web.de>
Cc: Junio C Hamano <gitster@pobox.com>,
Git Mailing List <git@vger.kernel.org>
Subject: Re: [PATCH] tests: fix overeager scrubbing of environment variables
Date: Sun, 27 Mar 2011 16:37:56 -0500 [thread overview]
Message-ID: <20110327213756.GD25927@elie> (raw)
In-Reply-To: <4D8FAAAC.3050905@web.de>
Jens Lehmann wrote:
> - GIT_SKIP_TESTS
> - GIT_TEST*
> - GIT_PROVE_OPTS
>
> Let's fix that by adding them to the exception list.
>
> Signed-off-by: Jens Lehmann <Jens.Lehmann@web.de>
Acked-by: Jonathan Nieder <jrnieder@gmail.com>
It misses a few, though:
- GIT_REMOTE_SVN_TEST_BIG_FILES
- GIT_NOTES_TIMING_TESTS
- GIT_PATCHID_TIMING_TESTS
- GIT_VALGRIND_OPTIONS
If we were starting over I suppose those would all be GIT_TEST* but
there's something to be said for muscle memory.
> I noticed today that skipping a test the way I was used to suddenly failed:
>
> GIT_SKIP_TESTS='t1234' GIT_TEST_OPTS='--root=/dev/shm' make -j10 test
>
> This should work according to t/README, but didn't anymore.
I would have just written that in the change description.
Good catch, thanks.
next prev parent reply other threads:[~2011-03-27 21:38 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-27 21:22 [PATCH] tests: fix overeager scrubbing of environment variables Jens Lehmann
2011-03-27 21:37 ` Jonathan Nieder [this message]
2011-03-27 22:17 ` [PATCH] squash! " Jonathan Nieder
2011-03-28 13:58 ` Jeff King
2011-03-27 22:26 ` [PATCH v2] " Jens Lehmann
2011-03-27 23:00 ` [PATCH/RFC] tests: use the --long-tests facility to toggle some slow tests Jonathan Nieder
2011-03-28 17:00 ` [PATCH] tests: fix overeager scrubbing of environment variables Junio C Hamano
2011-03-28 19:16 ` [PATCH v3] " Jens Lehmann
2011-03-28 19:37 ` Jonathan Nieder
2011-03-28 21:03 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110327213756.GD25927@elie \
--to=jrnieder@gmail.com \
--cc=Jens.Lehmann@web.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).