From: Jonathan Nieder <jrnieder@gmail.com>
To: Jens Lehmann <Jens.Lehmann@web.de>
Cc: Junio C Hamano <gitster@pobox.com>,
Git Mailing List <git@vger.kernel.org>, Jeff King <peff@peff.net>
Subject: Re: [PATCH v3] tests: fix overeager scrubbing of environment variables
Date: Mon, 28 Mar 2011 14:37:44 -0500 [thread overview]
Message-ID: <20110328193744.GB13433@elie> (raw)
In-Reply-To: <4D90DE79.7000103@web.de>
Jens Lehmann wrote:
> Acked-by: Jonathan Nieder <jrnieder@gmail.com>
Yes, still. :)
> So here is v3 of my patch which
> just makes these variables work again.
Thanks, all. This looks good for an immediate fix, and I can think
separately about how to make downstreams projects suffer less if
changing the names of variables like GIT_SKIP_TESTS to follow a
GIT_TEST_ scheme.
next prev parent reply other threads:[~2011-03-28 19:38 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-27 21:22 [PATCH] tests: fix overeager scrubbing of environment variables Jens Lehmann
2011-03-27 21:37 ` Jonathan Nieder
2011-03-27 22:17 ` [PATCH] squash! " Jonathan Nieder
2011-03-28 13:58 ` Jeff King
2011-03-27 22:26 ` [PATCH v2] " Jens Lehmann
2011-03-27 23:00 ` [PATCH/RFC] tests: use the --long-tests facility to toggle some slow tests Jonathan Nieder
2011-03-28 17:00 ` [PATCH] tests: fix overeager scrubbing of environment variables Junio C Hamano
2011-03-28 19:16 ` [PATCH v3] " Jens Lehmann
2011-03-28 19:37 ` Jonathan Nieder [this message]
2011-03-28 21:03 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110328193744.GB13433@elie \
--to=jrnieder@gmail.com \
--cc=Jens.Lehmann@web.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).