git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Antonio Ospite <ospite@studenti.unina.it>
To: git@vger.kernel.org
Cc: Junio C Hamano <gitster@pobox.com>
Subject: Minor cosmetic defect in git-pack-objects output
Date: Tue, 29 Mar 2011 12:10:40 +0200	[thread overview]
Message-ID: <20110329121040.de22bd56.ospite@studenti.unina.it> (raw)

[-- Attachment #1: Type: text/plain, Size: 1258 bytes --]

Hi,

in some cases, on git-pack-objects failure, there is a small defect in
the output, see:

# git gc --aggressive
Counting objects: 1954118, done.
Delta compression using up to 2 threads.
warning: suboptimal pack - out of memory02)   
Compressing objects: 100% (1936802/1936802), done.
Writing objects: 100% (1954118/1954118), done.
Total 1954118 (delta 1618716), reused 0 (delta 0)

The defect is here:
warning: suboptimal pack - out of memory02)
                                        ^^^
the trailing chars are from the replaced line which was ending in
1936802)

AFAICS this is basically what is happening:
#include "git-compat-util.h"
fprintf(stderr, "Compressing objects:  15% (296661/1936802)\r");
                 warning("suboptimal pack - out of memory");

I can think to a dumb workaround for this particular path but maybe
there are other places when this can happen as well.

Anyway it is not a big deal, but since I noticed it I wanted to report
that.

Regards,
   Antonio

-- 
Antonio Ospite
http://ao2.it

PGP public key ID: 0x4553B001

A: Because it messes up the order in which people normally read text.
   See http://en.wikipedia.org/wiki/Posting_style
Q: Why is top-posting such a bad thing?

[-- Attachment #2: Type: application/pgp-signature, Size: 198 bytes --]

             reply	other threads:[~2011-03-29 10:16 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-03-29 10:10 Antonio Ospite [this message]
2011-03-29 20:13 ` Minor cosmetic defect in git-pack-objects output René Scharfe
2011-03-29 20:48   ` Antonio Ospite

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110329121040.de22bd56.ospite@studenti.unina.it \
    --to=ospite@studenti.unina.it \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).