From: Jeff King <peff@peff.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: Johan Herland <johan@herland.net>,
Michael J Gruber <git@drmicha.warpmail.net>,
git@vger.kernel.org
Subject: Re: [PATCH] revision.c: introduce --notes-ref= to use one notes ref only
Date: Tue, 29 Mar 2011 16:53:08 -0400 [thread overview]
Message-ID: <20110329205307.GA30959@sigill.intra.peff.net> (raw)
In-Reply-To: <7vwrjhrd53.fsf@alter.siamese.dyndns.org>
On Tue, Mar 29, 2011 at 11:32:24AM -0700, Junio C Hamano wrote:
> Jeff King <peff@peff.net> writes:
>
> > Speaking of which, it is kind of weird that --show-notes is negated by
> > --no-notes. So maybe it makes sense to introduce "--notes[=<ref>]" to do
> > what I wrote above, and deprecate --show-notes.
>
> I think that is sensible.
>
> I personally think that "notes" are way too premature to be used seriously
> by normal people yet, and if we want to fix UI and semantics warts (it is
> understandable if we had plenty of them, simply because we didn't know
> enough about possible use cases during the period we prototyped the notes
> feature), the time to do so is now.
It is tempting to kill off --show-notes and --standard-notes, as it
would clean up this code a bit. But even though they are probably not
being seriously used by normal people, they have been in several
released versions.
Here's the series I ended up with. Getting the refactoring just right
turned out to be non-trivial, but between several attempts and some
tests, I think the end result is correct. Hopefully the breakdown of the
changes into small patches helps make it easy to review.
[1/6]: notes: make expand_notes_ref globally accessible
[2/6]: revision.c: refactor notes ref expansion
[3/6]: notes: refactor display notes extra refs field
[4/6]: notes: refactor display notes default handling
[5/6]: revision.c: support --notes command-line option
[6/6]: revision.c: make --no-notes reset --notes list
-Peff
next prev parent reply other threads:[~2011-03-29 20:53 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-29 10:05 [PATCH] revision.c: introduce --notes-ref= to use one notes ref only Michael J Gruber
2011-03-29 12:39 ` Johan Herland
2011-03-29 14:33 ` Jeff King
2011-03-29 15:16 ` Michael J Gruber
2011-03-29 18:32 ` Junio C Hamano
2011-03-29 20:53 ` Jeff King [this message]
2011-03-29 20:55 ` [PATCH 1/6] notes: make expand_notes_ref globally accessible Jeff King
2011-03-29 20:56 ` [PATCH 2/6] revision.c: refactor notes ref expansion Jeff King
2011-03-29 20:56 ` [PATCH 3/6] notes: refactor display notes extra refs field Jeff King
2011-03-29 20:57 ` [PATCH 4/6] notes: refactor display notes default handling Jeff King
2011-03-29 22:02 ` Junio C Hamano
2011-03-29 20:57 ` [PATCH 5/6] revision.c: support --notes command-line option Jeff King
2011-03-29 20:59 ` [PATCH 6/6] revision.c: make --no-notes reset --notes list Jeff King
2011-03-29 22:04 ` Junio C Hamano
2011-03-29 21:44 ` [PATCH] revision.c: introduce --notes-ref= to use one notes ref only Johan Herland
2011-03-29 22:18 ` [PATCH 7/6] log/pretty-options: Document --[no-]notes and deprecate old notes options Johan Herland
2011-03-30 0:22 ` Jeff King
2011-03-30 0:57 ` Johan Herland
2011-03-30 3:32 ` Jeff King
2011-03-29 14:35 ` [PATCH] revision.c: introduce --notes-ref= to use one notes ref only Jeff King
2011-03-29 19:01 ` Jeff King
2011-03-29 19:48 ` Michael J Gruber
2011-03-29 20:23 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110329205307.GA30959@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=git@drmicha.warpmail.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=johan@herland.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).