From: Jeff King <peff@peff.net>
To: Johan Herland <johan@herland.net>
Cc: git@vger.kernel.org, Junio C Hamano <gitster@pobox.com>,
Michael J Gruber <git@drmicha.warpmail.net>
Subject: Re: [PATCH 7/6] log/pretty-options: Document --[no-]notes and deprecate old notes options
Date: Tue, 29 Mar 2011 23:32:05 -0400 [thread overview]
Message-ID: <20110330033205.GB18157@sigill.intra.peff.net> (raw)
In-Reply-To: <201103300257.19921.johan@herland.net>
On Wed, Mar 30, 2011 at 02:57:19AM +0200, Johan Herland wrote:
> On Wednesday 30 March 2011, Jeff King wrote:
> > On Wed, Mar 30, 2011 at 12:18:55AM +0200, Johan Herland wrote:
> > > And here's some documentation to go on top.
> > [...]
> > This example is wrong. "--notes=foo" will show _only_ foo. A few
> > examples:
> >
> > --notes=foo ;# only foo
> > --notes --notes=foo ;# foo and default
> > --notes=foo --notes=bar --notes --no-notes --notes=foo ;# only foo
> >
> > Make sense?
>
> Yeah, I really screwed that up. Hope this version is better. :)
Yes, it looks good to me. Thanks.
Acked-by: Jeff King <peff@peff.net>
-Peff
next prev parent reply other threads:[~2011-03-30 3:32 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-29 10:05 [PATCH] revision.c: introduce --notes-ref= to use one notes ref only Michael J Gruber
2011-03-29 12:39 ` Johan Herland
2011-03-29 14:33 ` Jeff King
2011-03-29 15:16 ` Michael J Gruber
2011-03-29 18:32 ` Junio C Hamano
2011-03-29 20:53 ` Jeff King
2011-03-29 20:55 ` [PATCH 1/6] notes: make expand_notes_ref globally accessible Jeff King
2011-03-29 20:56 ` [PATCH 2/6] revision.c: refactor notes ref expansion Jeff King
2011-03-29 20:56 ` [PATCH 3/6] notes: refactor display notes extra refs field Jeff King
2011-03-29 20:57 ` [PATCH 4/6] notes: refactor display notes default handling Jeff King
2011-03-29 22:02 ` Junio C Hamano
2011-03-29 20:57 ` [PATCH 5/6] revision.c: support --notes command-line option Jeff King
2011-03-29 20:59 ` [PATCH 6/6] revision.c: make --no-notes reset --notes list Jeff King
2011-03-29 22:04 ` Junio C Hamano
2011-03-29 21:44 ` [PATCH] revision.c: introduce --notes-ref= to use one notes ref only Johan Herland
2011-03-29 22:18 ` [PATCH 7/6] log/pretty-options: Document --[no-]notes and deprecate old notes options Johan Herland
2011-03-30 0:22 ` Jeff King
2011-03-30 0:57 ` Johan Herland
2011-03-30 3:32 ` Jeff King [this message]
2011-03-29 14:35 ` [PATCH] revision.c: introduce --notes-ref= to use one notes ref only Jeff King
2011-03-29 19:01 ` Jeff King
2011-03-29 19:48 ` Michael J Gruber
2011-03-29 20:23 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110330033205.GB18157@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=git@drmicha.warpmail.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=johan@herland.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).