From: "Motiejus Jakštys" <desired.mta@gmail.com>
To: Alexandru Sutii <sutii.alex@gmail.com>
Cc: Vicent Marti <vicent@github.com>,
Jonathan Nieder <jrnieder@gmail.com>,
git@vger.kernel.org, libgit2@librelist.org,
Jeff King <peff@peff.net>
Subject: Re: GSoC questions
Date: Thu, 31 Mar 2011 14:06:05 +0300 [thread overview]
Message-ID: <20110331110605.GA14892@jakstys.lt> (raw)
In-Reply-To: <AANLkTinZ2zbhCRAqAYkiAa1=K8aUhcAuEe6Q_gO-v2h_@mail.gmail.com>
On Thu, Mar 31, 2011 at 12:36:15PM +0300, Alexandru Sutii wrote:
> I began implementing the minimal git client[1]. I have implemented the
> "git-mktag" command. For this I have modified the "mktag.c" file from
> the "builtin" directory in order to make it run with libgit2. Basically the
> input file verification code is the same with the original one. I have just
> extracted the sha1, the object type, the tag name, the tagger, the
> comment and created a tag with git_tag_create.
Hi there,
I started git2 client a couple of days ago and implemented a rough
version of rev-list.c (which shows rev-list of HEAD. It is here:
https://github.com/Motiejus/git2/
Vincent van Ravesteijn forked and made some modifications:
https://github.com/vfr-nl/git2/
Thanks to him for CMakeLists.txt.
>
> I have also used the original "usage.c" and "git-compat-util.h" for
> error handling. Is there a problem if the git2 client will reuse
> non-gitcore code, such as string parsing code, parameter parsing code,
> etc?
I think this is what it has to be like. Provided it adds no
requirements and license issues.
>
> Can someone look on my code and give me some feedback?
You have done a good job in creating handlers and hooking up the
repository. Thank you.
>
> Just before ending the implementation of the mktag command I have
> started thinking that maybe there was no need to reimplement this
> command, as it can be considered that libgit2 already has this
> feature. Even if it is so I am not sorry I did this, because by
> reimplementig it I had the chance to get used with git code and with
> libgit2 API.
Don't know about the actual tag implementation, but in any case, the
wrapper (glue) code around the tag very helpful.
Best,
Motiejus
next prev parent reply other threads:[~2011-03-31 11:06 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-27 9:20 GSoC questions Alexandru Sutii
2011-03-28 0:11 ` Jonathan Nieder
2011-03-28 14:35 ` Jeff King
2011-03-28 20:26 ` Alexandru Sutii
2011-03-28 20:52 ` Vicent Marti
2011-03-31 9:36 ` Alexandru Sutii
2011-03-31 11:06 ` Motiejus Jakštys [this message]
2011-03-31 11:58 ` Vincent van Ravesteijn
2011-03-31 18:34 ` Alexandru Sutii
2011-03-31 19:31 ` Jeff King
2011-03-31 19:27 ` Jeff King
2011-04-01 21:05 ` Vincent van Ravesteijn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110331110605.GA14892@jakstys.lt \
--to=desired.mta@gmail.com \
--cc=git@vger.kernel.org \
--cc=jrnieder@gmail.com \
--cc=libgit2@librelist.org \
--cc=peff@peff.net \
--cc=sutii.alex@gmail.com \
--cc=vicent@github.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).