From: Jeff King <peff@github.com>
To: Jon Seymour <jon.seymour@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] stash: fix false positive in the invalid ref test.
Date: Wed, 6 Apr 2011 14:27:26 -0400 [thread overview]
Message-ID: <20110406182726.GC8205@sigill.intra.peff.net> (raw)
In-Reply-To: <1302045673-59982-1-git-send-email-jon.seymour@gmail.com>
On Wed, Apr 06, 2011 at 09:21:13AM +1000, Jon Seymour wrote:
> diff --git a/t/t3903-stash.sh b/t/t3903-stash.sh
> index 11077f0..5263de7 100755
> --- a/t/t3903-stash.sh
> +++ b/t/t3903-stash.sh
> @@ -543,11 +543,11 @@ test_expect_success 'invalid ref of the form stash@{n}, n >= N' '
> echo bar6 > file2 &&
> git add file2 &&
> git stash &&
> - test_must_fail git drop stash@{1} &&
> - test_must_fail git pop stash@{1} &&
> - test_must_fail git apply stash@{1} &&
> - test_must_fail git show stash@{1} &&
> - test_must_fail git branch tmp stash@{1} &&
> + test_must_fail git stash drop stash@{1} &&
> + test_must_fail git stash pop stash@{1} &&
> + test_must_fail git stash apply stash@{1} &&
> + test_must_fail git stash show stash@{1} &&
> + test_must_fail git stash branch tmp stash@{1} &&
> git stash drop
Probably we should just squash your fix in with my first patch, and drop
my test. Your fixed version is a superset of what mine tests.
-Peff
next prev parent reply other threads:[~2011-04-06 18:27 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-05 23:21 [PATCH] stash: fix false positive in the invalid ref test Jon Seymour
2011-04-06 18:27 ` Jeff King [this message]
2011-04-06 22:47 ` Jon Seymour
2011-04-06 23:04 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110406182726.GC8205@sigill.intra.peff.net \
--to=peff@github.com \
--cc=git@vger.kernel.org \
--cc=jon.seymour@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).