git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jeff King <peff@peff.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH 2/4] add -u: get rid of "treewideupdate" configuration
Date: Fri, 8 Apr 2011 18:32:07 -0400	[thread overview]
Message-ID: <20110408223206.GA7343@sigill.intra.peff.net> (raw)
In-Reply-To: <7vmxk01izn.fsf@alter.siamese.dyndns.org>

On Fri, Apr 08, 2011 at 03:22:20PM -0700, Junio C Hamano wrote:

> So let's step back a bit.
> 
> How about we'd just add ':/' to make it equally easy to switch between
> "local only" vs "tree-wide" in 1.7.6 release, and be done with it.  We
> don't change the default for any of the commands at all.

Yeah, I am beginning to think that is a sensible route. And it commits
us to nothing, so if we decide much later that a change of default is
sensible, that is still open to us.

> Since more than a year ago, I've been saying that the ideal is to make the
> default not matter:
> 
>   http://thread.gmane.org/gmane.comp.version-control.git/133570/focus=133683
> 
> If the default does not matter, why change it?  It just causes us more
> headaches for dubious gain, no?

I'm not sure how much you can achieve the "make it not matter". The
shorthands go a long way, but I still want git to read my mind about
which I wanted to use (and the closest approximation of that, from my
experience, would be a per-repo variable). However, having the
shorthands mean that we can try them out in the real world and revisit
the topic in a year if people still care.

> IIRC, I think the two reasons why we started discussing of "add -u" and
> friends were that (1) some commands default to whole-tree while others
> limit to $cwd --- inconsistency is bad; and (2) when the user wants to do
> a full tree "add -u", there is no way other than counting the current
> depth and typing "../" that many times.
> 
> But when we looked at the current set of commands that limit them to the $cwd,
> we found that "add -u" was the only one that may make sense to switch the
> default, meaning that the "consistency" was not something we would even
> want to shoot for.  For example, we want our "git grep -e pattern" to
> mimic "grep -r -e pattern .".

I am not sure of that. I thought there was interest in full-tree grep
(OK, _I_ had some interst in it).  But the same transition pain
arguments apply there, and we should be able to do "git grep pattern :/"
soon, right?

-Peff

  reply	other threads:[~2011-04-08 22:32 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-04-07  1:16 [PATCH 0/4] Redoing the "add -u" migration plan Junio C Hamano
2011-04-07  1:16 ` [PATCH 1/4] magic pathspec: add tentative ":/path/from/top/level" pathspec support Junio C Hamano
2011-04-07  1:40   ` Junio C Hamano
2011-04-07 13:09     ` Nguyen Thai Ngoc Duy
2011-04-07 18:28       ` Junio C Hamano
2011-04-08 11:39         ` Nguyen Thai Ngoc Duy
2011-04-07 13:23   ` Nguyen Thai Ngoc Duy
2011-04-07 16:18     ` Junio C Hamano
2011-04-08 12:00       ` Nguyen Thai Ngoc Duy
2011-04-08 15:05         ` Junio C Hamano
2011-04-08 15:39           ` Nguyen Thai Ngoc Duy
2011-04-08 16:37           ` Junio C Hamano
2011-04-08 17:02             ` Nguyen Thai Ngoc Duy
2011-04-07  1:16 ` [PATCH 2/4] add -u: get rid of "treewideupdate" configuration Junio C Hamano
2011-04-08 17:54   ` Jeff King
2011-04-08 19:27     ` Junio C Hamano
2011-04-08 20:24       ` Jeff King
2011-04-08 22:22         ` Junio C Hamano
2011-04-08 22:32           ` Jeff King [this message]
2011-04-08 22:37             ` Junio C Hamano
2011-04-08 23:18               ` Junio C Hamano
2011-04-09  4:38                 ` Nguyen Thai Ngoc Duy
2011-04-09  4:56                   ` Junio C Hamano
2011-04-09  5:05                     ` Nguyen Thai Ngoc Duy
2011-04-09 21:34                       ` Junio C Hamano
2011-04-09  4:58                 ` Nguyen Thai Ngoc Duy
2011-04-09  5:20                   ` Junio C Hamano
2011-04-09 10:15                     ` Nguyen Thai Ngoc Duy
2011-04-09 11:24                   ` Nguyen Thai Ngoc Duy
2011-04-09 21:38                     ` Junio C Hamano
2011-05-03  7:52                 ` Nguyen Thai Ngoc Duy
2011-05-03 15:01                   ` Junio C Hamano
2011-05-03 16:17                     ` Nguyen Thai Ngoc Duy
2011-04-07  1:16 ` [PATCH 3/4] add: make "add -u/-A" update full tree without pathspec (step 2) Junio C Hamano
2011-04-07  1:16 ` [PATCH 4/4] add: make "add -u/-A" update full tree without pathspec (step 3) Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110408223206.GA7343@sigill.intra.peff.net \
    --to=peff@peff.net \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).