git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Ramkumar Ramachandra <artagnon@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: Git List <git@vger.kernel.org>
Subject: Re: [PATCH] revert: Hide '-r' option in default usage
Date: Wed, 13 Apr 2011 18:51:49 +0530	[thread overview]
Message-ID: <20110413132146.GB26760@kytes> (raw)
In-Reply-To: <7vhba4v6p8.fsf@alter.siamese.dyndns.org>

Hi Junio,

Junio C Hamano writes:
> Ramkumar Ramachandra <artagnon@gmail.com> writes:
> 
> > Since the '-r' command-line option is a no-op provided only for
> > backward compatiblity, don't advertise it in the default usage.
> >
> > Signed-off-by: Ramkumar Ramachandra <artagnon@gmail.com>
> > ---
> 
> Thanks.
> 
> It would have saved me a lot of time if you wrote that this option has
> been a no-op since abd6970 (cherry-pick: make -r the default, 2006-10-05),
> but the commit didn't remove it from the usage string, and it somehow
> survived 9509af6 (Make git-revert & git-cherry-pick a builtin, 2007-03-01)
> and later f810379 (Make builtin-revert.c use parse_options, 2007-10-07),
> and it is about time to stop advertising it.

Thanks.  I didn't realize there was so much history to write about.
Has you queued this somewhere?

-- Ram

  reply	other threads:[~2011-04-13 13:22 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-04-10 15:39 [PATCH] revert: Hide '-r' option in default usage Ramkumar Ramachandra
2011-04-11 21:06 ` Junio C Hamano
2011-04-13 13:21   ` Ramkumar Ramachandra [this message]
2011-04-13 18:09     ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110413132146.GB26760@kytes \
    --to=artagnon@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).