git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Carlos Martín Nieto" <cmn@elego.de>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] whatchanged: always show the header
Date: Wed, 13 Apr 2011 21:38:32 +0200	[thread overview]
Message-ID: <20110413193830.GA8560@bee.lab.cmartin.tk> (raw)
In-Reply-To: <7vlizem9bx.fsf@alter.siamese.dyndns.org>

On Wed, Apr 13, 2011 at 08:58:58AM -0700, Junio C Hamano wrote:
> Carlos Martín Nieto <cmn@elego.de> writes:
> 
> > Set the always_show_header option to fix this.
> 
> I don't think that is correct.  The command should skip empty commits, no?

Yes, from the man page, they should be skipped unless "-m" is passed.

> 
> I'll take a look at this later when I have time.  I plan to tag -rc2
> today.

Maybe unconditionally unsetting QUICK would give the desired
result. Tomorrow I should be done changing cmd_log_init to use the
parse options API so it's easier to catch "--quiet".

   cmn
 

  reply	other threads:[~2011-04-13 19:38 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-04-11 21:07 Bug in "git diff --quiet" handling Paul Gortmaker
2011-04-11 21:35 ` Junio C Hamano
2011-04-12 15:51   ` [PATCH] format-patch: document --quiet option Carlos Martín Nieto
2011-04-12 19:07     ` Junio C Hamano
2011-04-12 19:52       ` Junio C Hamano
2011-04-13  9:29         ` Carlos Martín Nieto
2011-04-12 15:35 ` [PATCH] format-patch: don't pass on the --quiet flag Carlos Martín Nieto
2011-04-12 18:56   ` Junio C Hamano
2011-04-13  9:26     ` Carlos Martín Nieto
2011-04-13 12:10       ` [PATCH] whatchanged: always show the header Carlos Martín Nieto
2011-04-13 15:58         ` Junio C Hamano
2011-04-13 19:38           ` Carlos Martín Nieto [this message]
2011-04-14 14:28           ` [PATCH] log: convert to parse-options Carlos Martín Nieto
2011-04-14 17:08             ` Junio C Hamano
2011-04-19 12:33               ` =?UTF-8?q?Carlos=20Mart=C3=ADn=20Nieto?=
2011-04-20  2:38                 ` Jeff King
2011-04-20 14:51                   ` Carlos Martín Nieto

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110413193830.GA8560@bee.lab.cmartin.tk \
    --to=cmn@elego.de \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).