From: Jeff King <peff@peff.net>
To: Jonathan Nieder <jrnieder@gmail.com>
Cc: Jacek Masiulaniec <jacekm@dobremiasto.net>,
git@vger.kernel.org, Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH] status: store format option as an int
Date: Sat, 16 Apr 2011 02:22:33 -0400 [thread overview]
Message-ID: <20110416062233.GA28853@sigill.intra.peff.net> (raw)
In-Reply-To: <20110416052704.GA10807@elie>
On Sat, Apr 16, 2011 at 12:27:04AM -0500, Jonathan Nieder wrote:
> It is unsafe to pass a pointer to a value of enumerated type to
> OPT_SET_INT (as v1.7.0-rc0~137^2~14, 2009-0905) does, since it might
> have the wrong alignment or width (C99 only says "Each enumerated type
> shall be compatible with char, a signed integer type, or an unsigned
> integer type. The choice of type is implementation-defined, but shall
> be capable of representing the values of all the members of the
> enumeration.)
>
> Probably this didn't come up in practice because by default GCC uses
> an 'int' to represent small enums unless passed -fshort-enums (except
> on certain architectures where -fshort-enums is the default).
>
> Noticed-by: Jeff King <peff@peff.net>
If by "noticed by" you mean "mentioned but was completely unaware of the
significance of what he was saying", then yes. :)
Now that you mention it, though, I was reminded that we had run across
something similar before. And I think it was this:
http://article.gmane.org/gmane.comp.version-control.git/144858
Your fix looks sane. I don't think we can do anything more clever on the
parse-options side.
-Peff
next prev parent reply other threads:[~2011-04-16 6:22 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-15 21:34 git status -s -v: no override Jacek Masiulaniec
2011-04-16 0:09 ` Jeff King
2011-04-16 0:45 ` Jonathan Nieder
2011-04-16 1:37 ` Jeff King
2011-04-16 5:27 ` [PATCH] status: store format option as an int Jonathan Nieder
2011-04-16 5:29 ` Jonathan Nieder
2011-04-16 6:14 ` Junio C Hamano
2011-04-16 6:28 ` Jonathan Nieder
2011-04-16 6:22 ` Jeff King [this message]
2011-05-15 4:05 ` [PATCH resend] " Jonathan Nieder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110416062233.GA28853@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jacekm@dobremiasto.net \
--cc=jrnieder@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).