git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jeff King <peff@peff.net>
To: madmarcos <fru574@my.utsa.edu>
Cc: git@vger.kernel.org
Subject: Re: Java Inflater problem decompressing packfile
Date: Sun, 17 Apr 2011 00:36:07 -0400	[thread overview]
Message-ID: <20110417043607.GA10831@sigill.intra.peff.net> (raw)
In-Reply-To: <1302963832717-6279028.post@n2.nabble.com>

On Sat, Apr 16, 2011 at 07:23:52AM -0700, madmarcos wrote:

> No, my inflater doesn't handle deltas, yet. 
> But there are a few reasons why I don't think that's the case.
> 1. The project has only been pushed once to the git repository before my
> tests. No updates to the git repository project or anything like that. 

You can still have deltas between blobs in a single commit, but only if
you have similar blobs.

> 2. If it were a delta, would the first 1/3 of it be completely normal and
> readable? There is no pattern that I can see to the remaining 2/3. It looks
> as if the characters in the 2/3 part were interleaved with the other
> characters about 10 times.

It wouldn't be completely normal, but you might see chunks of the file
along with binary patch instructions (like "put this chunk at offset
...").

> 3. The object type in the header is parsed as 3, or a blob. Aren't the delta
> object types higher numbers than that?

Yeah, if it is coming up as type 3, then it should definitely be a
whole, literal blob.

As far as your Java code, I don't see anything overtly wrong, but then,
I know absolutely nothing about any of the classes you are using.

-Peff

      parent reply	other threads:[~2011-04-17  4:36 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-04-16  2:05 Java Inflater problem decompressing packfile madmarcos
2011-04-16  6:37 ` Jeff King
2011-04-16 14:23   ` madmarcos
2011-04-16 14:36     ` madmarcos
2011-04-16 14:58       ` madmarcos
2011-04-16 15:50         ` madmarcos
2011-04-17  0:40           ` madmarcos
2011-04-17  4:02             ` madmarcos
2011-04-17  4:06               ` madmarcos
2011-04-17  4:36     ` Jeff King [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110417043607.GA10831@sigill.intra.peff.net \
    --to=peff@peff.net \
    --cc=fru574@my.utsa.edu \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).