* [PATCH] gitk: When a commit contains a note, mark it with a yellow box.
@ 2011-04-19 20:37 Raphael Zimmerer
0 siblings, 0 replies; only message in thread
From: Raphael Zimmerer @ 2011-04-19 20:37 UTC (permalink / raw)
To: Paul Mackerras; +Cc: git
It is desirable to see at a glance which commits do contain notes.
Therefore mark them with a yellow rectangle.
That can be suppressed with `gitk --no-notes`.
Signed-off-by: Raphael Zimmerer <killekulla@rdrz.de>
---
Maybe this patch is helpful. Sorry for any tcl/tk nonsense, it's not
my first language...
gitk | 17 ++++++++++++++++-
1 files changed, 16 insertions(+), 1 deletions(-)
diff --git a/gitk b/gitk
index 4cde0c4..b182c75 100755
--- a/gitk
+++ b/gitk
@@ -1674,8 +1674,9 @@ proc parsecommit {id contents listed} {
if {$comdate != {}} {
set cdate($id) $comdate
}
+ set hasnote [string first "\nNotes:\n" $contents]
set commitinfo($id) [list $headline $auname $audate \
- $comname $comdate $comment]
+ $comname $comdate $comment $hasnote]
}
proc getcommit {id} {
@@ -5899,6 +5900,9 @@ proc drawcmittext {id row col} {
|| [info exists idotherrefs($id)]} {
set xt [drawtags $id $x $xt $y]
}
+ if {[lindex $commitinfo($id) 6] > 0} {
+ set xt [drawnotesign $xt $y]
+ }
set headline [lindex $commitinfo($id) 0]
set name [lindex $commitinfo($id) 1]
set date [lindex $commitinfo($id) 2]
@@ -6345,6 +6349,17 @@ proc drawtags {id x xt y1} {
return $xt
}
+proc drawnotesign {xt y} {
+ global linespc canv fgcolor
+
+ set orad [expr {$linespc / 3}]
+ set t [$canv create rectangle [expr {$xt - $orad}] [expr {$y - $orad}] \
+ [expr {$xt + $orad - 1}] [expr {$y + $orad - 1}] \
+ -fill yellow -outline $fgcolor -width 1 -tags circle]
+ set xt [expr {$xt + $orad * 3}]
+ return $xt
+}
+
proc xcoord {i level ln} {
global canvx0 xspc1 xspc2
--
1.7.5.rc1.12.gff46a
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2011-04-19 20:44 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-04-19 20:37 [PATCH] gitk: When a commit contains a note, mark it with a yellow box Raphael Zimmerer
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).