From: "Carlos Martín Nieto" <cmn@elego.de>
To: Jeff King <peff@peff.net>
Cc: Junio C Hamano <gitster@pobox.com>, git@vger.kernel.org
Subject: Re: [PATCH] log: convert to parse-options
Date: Wed, 20 Apr 2011 16:51:20 +0200 [thread overview]
Message-ID: <20110420145120.GC5236@bee.lab.cmartin.tk> (raw)
In-Reply-To: <20110420023817.GA14201@sigill.intra.peff.net>
On Tue, Apr 19, 2011 at 10:38:17PM -0400, Jeff King wrote:
> On Tue, Apr 19, 2011 at 02:33:31PM +0200, =?UTF-8?q?Carlos=20Mart=C3=ADn=20Nieto?= wrote:
>
> > Signed-off-by: Carlos Martín Nieto <cmn@elego.de>
>
> This is not about your patch at all, but rather that I notice in your
> "From" header that your name is doubly rfc2047-encoded. It looks like
> this:
>
> From: =?us-ascii?B?PT9VVEYtOD9xP0Nhcmxvcz0yME1hcnQ9QzM9QURuPTIwTmlldG8/?=
> =?us-ascii?Q?=3D?= <cmn@elego.de>
>
> which decodes to the literal string:
>
> =?UTF-8?q?Carlos=20Mart=C3=ADn=20Nieto?=
>
> which in turn decodes again to your proper name.
>
Ah, so that's what been going on.
> We made some changes to format-patch's quoting recently, and I want to
> make sure this is not a regression. Can you describe your workflow for
> sending these patches? What I think probably happened is:
>
> 1. format-patch encoded your name because of the non-ascii characters
>
> 2. the result was fed literally into mutt via cut-and-paste or
> otherwise pulled into the editor, rather than "mutt -f patch-file".
>
> Which is not a regression, but just an annoying behavior that has been
> there for a while[1]. But I wanted to double-check.
As I was only sending one patch, I did what the intertubes suggested
and used "mutt -H patch-file" which I guess that's the problem. I only
noticed this because someone mentioned it, after I sent another patch.
So no regression, and a --leave-utf8-alone option would be useful here.
Cheers,
cmn
prev parent reply other threads:[~2011-04-20 14:51 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-11 21:07 Bug in "git diff --quiet" handling Paul Gortmaker
2011-04-11 21:35 ` Junio C Hamano
2011-04-12 15:51 ` [PATCH] format-patch: document --quiet option Carlos Martín Nieto
2011-04-12 19:07 ` Junio C Hamano
2011-04-12 19:52 ` Junio C Hamano
2011-04-13 9:29 ` Carlos Martín Nieto
2011-04-12 15:35 ` [PATCH] format-patch: don't pass on the --quiet flag Carlos Martín Nieto
2011-04-12 18:56 ` Junio C Hamano
2011-04-13 9:26 ` Carlos Martín Nieto
2011-04-13 12:10 ` [PATCH] whatchanged: always show the header Carlos Martín Nieto
2011-04-13 15:58 ` Junio C Hamano
2011-04-13 19:38 ` Carlos Martín Nieto
2011-04-14 14:28 ` [PATCH] log: convert to parse-options Carlos Martín Nieto
2011-04-14 17:08 ` Junio C Hamano
2011-04-19 12:33 ` =?UTF-8?q?Carlos=20Mart=C3=ADn=20Nieto?=
2011-04-20 2:38 ` Jeff King
2011-04-20 14:51 ` Carlos Martín Nieto [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110420145120.GC5236@bee.lab.cmartin.tk \
--to=cmn@elego.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).