git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jonathan Nieder <jrnieder@gmail.com>
To: Ramsay Jones <ramsay@ramsay1.demon.co.uk>
Cc: Junio C Hamano <gitster@pobox.com>, Jeff King <peff@peff.net>,
	GIT Mailing-list <git@vger.kernel.org>
Subject: Re: [RFC/PATCH] t0081-*.sh: Fix failure of the 'long read' tests
Date: Tue, 26 Apr 2011 14:35:39 -0500	[thread overview]
Message-ID: <20110426193539.GA2616@elie> (raw)
In-Reply-To: <4DB70972.20308@ramsay1.demon.co.uk>

Ramsay Jones wrote:

> --- a/t/t0081-line-buffer.sh
> +++ b/t/t0081-line-buffer.sh
> @@ -25,8 +25,7 @@ generate_tens_of_lines () {
>  		do
>  			echo "$line"
>  		done &&
> -		: $((i = $i + 1)) ||
> -		return
> +		i=$(($i + 1))
>  	done

This test is a mess.  Could you try the patch from the tip of

	git://repo.or.cz/git/jrn.git svn-fe

which just gets rid of it instead?

Thanks for a reminder.

  reply	other threads:[~2011-04-26 19:35 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-04-26 18:05 [RFC/PATCH] t0081-*.sh: Fix failure of the 'long read' tests Ramsay Jones
2011-04-26 19:35 ` Jonathan Nieder [this message]
2011-04-30 17:12   ` Ramsay Jones
2011-04-26 23:48 ` Jeff King
2011-04-30 17:25   ` Ramsay Jones
2011-05-26  4:33     ` [PULL svn-fe/maint] " Jonathan Nieder
2011-05-26 16:03       ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110426193539.GA2616@elie \
    --to=jrnieder@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=peff@peff.net \
    --cc=ramsay@ramsay1.demon.co.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).