From: Jonathan Nieder <jrnieder@gmail.com>
To: Michael Schubert <mschub@elegosoft.com>
Cc: git@vger.kernel.org, Michael J Gruber <git@drmicha.warpmail.net>,
Andreas Ericsson <ae@op5.se>
Subject: Re: [PATCH] run-command.c: Fix unused variables warning with gcc 4.6
Date: Tue, 26 Apr 2011 20:16:14 -0500 [thread overview]
Message-ID: <20110427011614.GA14181@elie> (raw)
In-Reply-To: <4DB6BA5E.3040306@elegosoft.com>
Hi Michael,
Michael Schubert wrote:
> As of gcc 4.6 -Wall includes -Wunused-but-set-variable. Remove all
> unused variables to prevent those warnings.
As the other Michael mentioned, this patch replaces one warning with
another. You might like a111eb7 (run-command: handle short writes and
EINTR in die_child, 2011-04-20, aka jn/run-command-error-failure in
"pu"), which eliminates both.
Andreas, a patch on top to short-circuit away the later writes on
error doesn't sound bad to me if you'd like, though it seems like a
bit of an edge case.
Thanks, all.
Jonathan
prev parent reply other threads:[~2011-04-27 1:16 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-26 12:28 [PATCH] run-command.c: Fix unused variables warning with gcc 4.6 Michael Schubert
2011-04-26 13:13 ` Michael J Gruber
2011-04-26 13:27 ` Michael Schubert
2011-04-26 13:45 ` Andreas Ericsson
2011-04-27 1:16 ` Jonathan Nieder [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110427011614.GA14181@elie \
--to=jrnieder@gmail.com \
--cc=ae@op5.se \
--cc=git@drmicha.warpmail.net \
--cc=git@vger.kernel.org \
--cc=mschub@elegosoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).