git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jeff King <peff@peff.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: Csaba Henk <csaba@lowlife.hu>, git@vger.kernel.org
Subject: Re: git symbolic-ref vs. reflog (vs. rebase)
Date: Fri, 29 Apr 2011 18:48:30 -0400	[thread overview]
Message-ID: <20110429224829.GC3434@sigill.intra.peff.net> (raw)
In-Reply-To: <7vk4edyqqn.fsf@alter.siamese.dyndns.org>

On Fri, Apr 29, 2011 at 09:19:44AM -0700, Junio C Hamano wrote:

> Csaba Henk <csaba@lowlife.hu> writes:
> 
> > "git symbolic-ref" is a dangerous command in the sense that it can
> > change your HEAD position without updating the reflog. Is it
> > intended behaviour?
> 
> Yes, it is.  But you can choose to do:
> 
> 	$ git branch side
> 	$ git symoblic-ref -m "move to side" HEAD refs/heads/side
>         $ git log --oneline -g HEAD@{0}
>         05ddb9b HEAD@{0}: move to side
> 	e69de29 HEAD@{1}: commit (initial): first commit
> 
> if you wanted to.

I think every caller should be using "-m" these days.  I know we can't
_require_ it for historical reasons. But shouldn't symbolic-ref always
write a reflog entry? Even something like "we changed and I can't tell
you why" to cover older scripts that call symbolic-ref?

-Peff

  parent reply	other threads:[~2011-04-29 22:48 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-04-29 15:03 git symbolic-ref vs. reflog (vs. rebase) Csaba Henk
2011-04-29 16:19 ` Junio C Hamano
2011-04-29 17:21   ` Csaba Henk
2011-04-30  4:13     ` Jeff King
2011-05-02  8:46       ` Csaba Henk
2011-05-27 20:13         ` [PATCH 1/2] rebase: create HEAD reflog entry when aborting Jeff King
2011-05-27 20:16         ` [PATCH 2/2] rebase: write a reflog entry when finishing Jeff King
2011-04-29 22:48   ` Jeff King [this message]
2011-04-29 23:00     ` git symbolic-ref vs. reflog (vs. rebase) Junio C Hamano
2011-04-30  3:58       ` Jeff King
2011-05-02  8:38       ` Csaba Henk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110429224829.GC3434@sigill.intra.peff.net \
    --to=peff@peff.net \
    --cc=csaba@lowlife.hu \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).