git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jakub Narebski <jnareb@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org,
	John 'Warthog9' Hawley <warthog9@eaglescrag.net>,
	John 'Warthog9' Hawley <warthog9@kernel.org>,
	Uwe Kleine-Koenig <u.kleine-koenig@pengutronix.de>,
	Jonathan Nieder <jrnieder@gmail.com>, Petr Baudis <pasky@suse.cz>,
	Sebastien Cevey <seb@cine7.net>
Subject: Re: [PATCH 0/6] gitweb: Improve ctags, introduce categories
Date: Sat, 30 Apr 2011 01:53:06 +0200	[thread overview]
Message-ID: <201104300153.09304.jnareb@gmail.com> (raw)
In-Reply-To: <7v8vuswxqs.fsf@alter.siamese.dyndns.org>

Junio C Hamano wrote:

> A tangent. It is curious why [PATCH 2/6] alone ended up with an encoded
> "Subject" header, like this:
> 
>   Subject: =?UTF-8?q?=5BPATCH=202/6=5D=20gitweb=3A=20Change=20the=20
>    way=20=22content=20tags=22=20=28=27ctags=27=29=20are=20handled?=
> 
> The message actually has the above as a long single line, as can be seen
> at http://article.gmane.org/gmane.comp.version-control.git/172479/raw
> 
> Just being curious.
> 
> The headers suggest that sending MUA was git-send-email speaking to gmail
> SMTP.  Did we introduce bugs to send-email recently?

This is git-send-email from git version 1.7.3 (not most recent).

What might be important, and what you can't get from mail itself, is that
patch was generated using git-format-patch, but UTF-8 characters in body
of email were introduced during editing it, and were not present in commit
message (sorry, bad practice).  So git-send-email asked about encoding,
and I chosen default UTF-8

  The following files are 8bit, but do not declare a Content-Transfer-Encoding.
      mdir.7/0002-gitweb-Change-the-way-content-tags-ctags-are-handled.txt
  Which 8bit encoding should I declare [UTF-8]? <ENTER>

Though subject itself does contain only 7bit US-ASCII, so there is no need
for encoding it (with quoted-printable, as Subject appears before 
Content-Encoding and MIME-Version headers).

-- 
Jakub Narebski
Poland

  reply	other threads:[~2011-04-29 23:53 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-04-29 17:51 [PATCH 0/6] gitweb: Improve ctags, introduce categories Jakub Narebski
2011-04-29 17:51 ` [PATCH 1/6 (v2)] gitweb: Restructure projects list generation Jakub Narebski
2011-05-07 18:39   ` Jakub Narebski
2011-04-29 17:51 ` [PATCH 2/6] gitweb: Change the way "content tags" ('ctags') are handled Jakub Narebski
2011-04-29 17:51 ` [PATCH 3/6] gitweb: Mark matched 'ctag' / contents tag (?by_tag=foo) Jakub Narebski
2011-04-29 17:51 ` [PATCH 4/6] gitweb: Split git_project_list_body in two functions Jakub Narebski
2011-04-29 17:52 ` [PATCH 5/6] gitweb: Modularized git_get_project_description to be more generic Jakub Narebski
2011-04-29 17:52 ` [PATCH 6/6] gitweb: Optional grouping of projects by category Jakub Narebski
2011-04-29 21:31 ` [PATCH 0/6] gitweb: Improve ctags, introduce categories Junio C Hamano
2011-04-29 23:53   ` Jakub Narebski [this message]
2011-04-30 20:36   ` Øyvind A. Holm
2011-05-03 14:02     ` git-send-email and non 7bit clean message (was: [PATCH 0/6] gitweb: Improve ctags, introduce categories) Jakub Narebski
2011-05-04 13:50       ` [PATCH/RFC] git-send-email: Do not encode Subject if not required (was: git-send-email and non 7bit clean message) Jakub Narebski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201104300153.09304.jnareb@gmail.com \
    --to=jnareb@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=jrnieder@gmail.com \
    --cc=pasky@suse.cz \
    --cc=seb@cine7.net \
    --cc=u.kleine-koenig@pengutronix.de \
    --cc=warthog9@eaglescrag.net \
    --cc=warthog9@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).