git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jonathan Nieder <jrnieder@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: Jon Seymour <jon.seymour@gmail.com>, git@vger.kernel.org
Subject: Re: [PATCH] Add --info-path and --man-path options to git.
Date: Sun, 1 May 2011 18:48:33 -0500	[thread overview]
Message-ID: <20110501234833.GC11550@elie> (raw)
In-Reply-To: <7vbozmthhy.fsf@alter.siamese.dyndns.org>

Junio C Hamano wrote:

> This an improvement that is pretty much independent from the issue of
> third party extensions. In fact, even people who would oppose to the idea
> of any third party crap [*1*] contaminating the install directories owned
> by git may want to this patch.
>
> It is useful to have these options even for read-only users. Cf. 89a56bf
> (add --html-path to get the location of installed HTML docs, 2009-04-05).

I don't mind this patch at all, but I do not have a full picture yet
of how it helps.

In the case of HTML, the standard way to show git documentation in your
custom documentation viewer is to pull up file://$(git --html-path)/index.html,
using the full path to the HTML files.  So if "git gui" were to gain a
documentation viewer widget instead of relying on git web--browse, it
would need the HTML path.

By contrast, man and info typically use standard search mechanisms:
man using $MANPATH and info using the dir.info file.  The usual
interface to git's documentation through a man browser is not

	man /usr/share/man/man1/git-add.1.gz

but

	man git-add;	# or "man git add" if your man viewer supports it

And the usual interface through an info browser is

	info git

.

So it is not clear to me how this would help when you want to view
documentation.  Similarly, if you want to sneak documentation into an
existing git installation (ignoring the question of whether that's a
good idea), using HTML you would have to modify git's index.html and
add your HTML files alongside it, while using "man" or "info" you
would have to modify the index page (git.1 or gitman.info) but could
put your custom pages wherever you want in the viewer's search path.

So while I can't see the harm in exposing --info-path and --man-path,
the current patch seems to do an incomplete job of documenting them.
Perhaps this is about finding the documentation corresponding to a
particular copy of git when a machine has multiple copies?

  parent reply	other threads:[~2011-05-01 23:48 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-05-01  8:16 [PATCH] Add --info-path and --man-path options to git Jon Seymour
2011-05-01 18:15 ` Junio C Hamano
2011-05-01 22:47   ` Jon Seymour
2011-05-01 23:48   ` Jonathan Nieder [this message]
2011-05-01 23:53     ` Jonathan Nieder
2011-05-02  0:02     ` Junio C Hamano
2011-05-02  0:06       ` Jon Seymour
2011-05-02  0:12         ` Jon Seymour
2011-05-02  0:25       ` Jonathan Nieder
2011-05-02  3:47         ` Junio C Hamano
2011-05-02  5:15           ` Jonathan Nieder
2011-05-02  6:07 ` [PATCH] Documentation: clarify meaning of --html-path, --man-path, and --info-path Jonathan Nieder
2011-05-02  6:49   ` Jon Seymour
2011-05-02 17:24   ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110501234833.GC11550@elie \
    --to=jrnieder@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=jon.seymour@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).