From: Jeff King <peff@peff.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org
Subject: Re: [Annoyance] "git log .." thinks ".." is ambiguous
Date: Mon, 2 May 2011 16:42:35 -0400 [thread overview]
Message-ID: <20110502204235.GA13584@sigill.intra.peff.net> (raw)
In-Reply-To: <7vhb9clu0n.fsf@alter.siamese.dyndns.org>
On Mon, May 02, 2011 at 01:36:24PM -0700, Junio C Hamano wrote:
> And a matching "rev-parse" update should look like this. I wonder if we
> could share some code between the two, though...
>
> Documentation/revisions.txt | 7 +++++++
> builtin/rev-parse.c | 16 ++++++++++++++--
> 2 files changed, 21 insertions(+), 2 deletions(-)
The doc update looks good to me. The duplication in rev-parse is pretty
gross, but that is certainly not a problem you are introducing. It would
be nice to clean it up, but I don't know how painful that would be. It
seems like rev-parse should just be calling handle_revision_arg, but I'm
sure there are some nasty corner cases. IOW, I am not volunteering. :)
-Peff
next prev parent reply other threads:[~2011-05-02 20:42 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-02 19:15 [Annoyance] "git log .." thinks ".." is ambiguous Junio C Hamano
2011-05-02 19:33 ` Jeff King
2011-05-02 19:36 ` Jeff King
2011-05-02 20:36 ` Junio C Hamano
2011-05-02 20:42 ` Jeff King [this message]
2011-05-02 20:56 ` [PATCH v2] specifying ranges: we did not mean to make ".." an empty set Junio C Hamano
2011-05-02 21:01 ` Jeff King
2011-05-02 21:48 ` Junio C Hamano
2011-05-03 6:39 ` Michael J Gruber
2011-05-03 17:38 ` Junio C Hamano
2011-05-04 6:55 ` Michael J Gruber
2011-05-04 15:36 ` Junio C Hamano
2011-05-04 18:00 ` Junio C Hamano
2011-05-03 1:57 ` [Annoyance] "git log .." thinks ".." is ambiguous Joshua Juran
2011-05-03 6:33 ` Michael J Gruber
2011-05-03 8:17 ` Joshua Juran
2011-05-03 8:45 ` Michael J Gruber
2011-05-03 19:00 ` Junio C Hamano
2011-05-03 8:38 ` John Szakmeister
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110502204235.GA13584@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).