From: Jeff King <peff@peff.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: Brian Gernhardt <brian@gernhardtsoftware.com>,
"git@vger.kernel.org List" <git@vger.kernel.org>
Subject: Re: t5541: Bad file descriptor
Date: Thu, 5 May 2011 01:46:11 -0400 [thread overview]
Message-ID: <20110505054611.GA29033@sigill.intra.peff.net> (raw)
In-Reply-To: <7voc3hbtgu.fsf@alter.siamese.dyndns.org>
On Wed, May 04, 2011 at 10:35:13PM -0700, Junio C Hamano wrote:
> Brian Gernhardt <brian@gernhardtsoftware.com> writes:
>
> > I haven't had a lot of time to track down it down until today, but I've
> > been getting failures in t5541-http-push-.sh. Several tests fail with
> > the error "fatal: write error: Bad file descriptor".
>
> A wild guess.
>
> Does it help if you cherry-picked 1e41827 (http: clear POSTFIELDS when
> initializing a slot, 2011-04-26) on top of the faulty commit?
I think that 09c9957 (send-pack: avoid deadlock when pack-object dies
early, 2011-04-25) is totally broken.
Looking back at my tests, I only tested the case where pack-objects
fails. And it seems we totally broke the case where the push is supposed
to succeed.
Still investigating...
-Peff
next prev parent reply other threads:[~2011-05-05 5:46 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-05 4:49 t5541: Bad file descriptor Brian Gernhardt
2011-05-05 5:35 ` Junio C Hamano
2011-05-05 5:46 ` Jeff King [this message]
2011-05-05 6:16 ` Jeff King
2011-05-05 11:18 ` Sverre Rabbelier
2011-05-05 17:59 ` Avery Pennarun
2011-05-05 18:51 ` Sverre Rabbelier
2011-05-09 14:50 ` Jeff King
2011-05-05 6:18 ` Jeff King
2011-05-05 6:57 ` Brian Gernhardt
2011-05-05 20:42 ` Johannes Sixt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110505054611.GA29033@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=brian@gernhardtsoftware.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).