From: Arjen Laarhoven <arjen@yaph.org>
To: Junio C Hamano <gitster@pobox.com>
Cc: Brian Gernhardt <brian@gernhardtsoftware.com>,
Git List <git@vger.kernel.org>
Subject: Re: [PATCH] t/annotate-tests: Use echo & cat instead of sed
Date: Thu, 5 May 2011 09:43:43 +0200 [thread overview]
Message-ID: <20110505074343.GA17328@regex.yaph.org> (raw)
In-Reply-To: <7vk4e5bt90.fsf@alter.siamese.dyndns.org>
On Wed, May 04, 2011 at 10:39:55PM -0700, Junio C Hamano wrote:
> An earlier patch from Arjen Laarhoven
>
> From: Arjen Laarhoven <arjen@yaph.org>
> Subject: [PATCH] annotate.sh: Fix failing test on OS X
> Date: Wed, 4 May 2011 15:36:21 +0200
> Message-ID: <1304516181-92364-1-git-send-email-arjen@yaph.org>
>
> seems to attempt to address the same issue but with a twist to deal with
> an incomplete line at the end of file.
>
> Arjen, does Brian's patch look good to you, too? It is much less tricky
> and should look obviously correct even to people who sees the code in
> question for the first time.
Yup, this looks much better than my fix. At least I learned something
about the sed incompatibilities ;-)
Arjen
--
Arjen Laarhoven
The presence of those seeking the truth is infinitely to be preferred to
those who think they've found it.
-- Terry Pratchett, "Monstrous Regiment"
prev parent reply other threads:[~2011-05-05 7:43 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-05 4:43 [PATCH] t/annotate-tests: Use echo & cat instead of sed Brian Gernhardt
2011-05-05 5:39 ` Junio C Hamano
2011-05-05 7:43 ` Arjen Laarhoven [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110505074343.GA17328@regex.yaph.org \
--to=arjen@yaph.org \
--cc=brian@gernhardtsoftware.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).