From: Kacper Kornet <kornet@camk.edu.pl>
To: Junio C Hamano <gitster@pobox.com>
Cc: Johannes Sixt <j.sixt@viscovery.net>, git@vger.kernel.org
Subject: Re: [PATCH 1/1] Honor $(prefix) set in config.mak* when defining ETC_GIT* and sysconfdir
Date: Thu, 5 May 2011 16:29:10 +0200 [thread overview]
Message-ID: <20110505142910.GA31229@camk.edu.pl> (raw)
In-Reply-To: <7vwri5c27e.fsf@alter.siamese.dyndns.org>
On Wed, May 04, 2011 at 07:26:29PM -0700, Junio C Hamano wrote:
> Junio C Hamano <gitster@pobox.com> writes:
> > So I think it would probably be a less-impact and useful solution to keep
> > sysconfdir and add "sysconfdir = @sysconfdir@" to config.mak.in as well.
> > Is Kacper's latest patch with an obvious one-liner to config.mak.in
> > sufficient to achieve that?
> > From: Kacper Kornet <kornet@camk.edu.pl>
> > Subject: Re: [PATCH 1/1] Honor $(prefix) set in config.mak* when defin...
> > Date: Wed, 4 May 2011 16:29:21 +0200
> > Message-ID: <20110504142921.GE18585@camk.edu.pl>
> In other words, this one on top of the above (which defaults sysconfdir
> to /etc when $(prefix) is /usr and then sets git_etcdir to $(sysconfdir)).
There is one more problem with this. If you call:
./configure --prefix=/usr --sysconfdir=/<dir>
sysconfdir and git_etcdir are set to /etc not /<dir>. I admit that it is
a rather unusual set of options ./configure, but maybe it should be
supported. So maybe I will first describe how it should all work in my
opinion and I will wait for comments before I will try to implement it.
1. ./configure --prefix=dir1 and dir1 != /usr
git_etcdir = etc
2. ./configure --prefix=/usr
git_etcdir = /etc
3. ./configure --prefix=dir1 --syscondir=dir2 (here dir2 has to be an
absolute path)
git_etcdir = dir2
4. make prefix=dir1 and dir1 != /usr
git_etcdir = etc
5. make prefix=/usr
git_etcdir = /etc
6. make prefix=dir1 sysconfdir=dir2 (here dir2 can be an absolute or
a relative path)
git_etcdir = dir2
--
Kacper Kornet
next prev parent reply other threads:[~2011-05-05 14:29 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-28 2:29 [PATCH] Respect definition of prefix from autotools in ETC_GITCONFIG and ETC_GITATTRIBUTES Kacper Kornet
2011-04-28 16:54 ` Junio C Hamano
2011-04-28 17:49 ` Kacper Kornet
2011-04-28 19:27 ` [PATCH 1/1] Honor $(prefix) set in config.mak* when defining ETC_GIT* and sysconfdir Kacper Kornet
2011-04-28 20:01 ` [PATCH] Honor sysconfdir when set as an configure option Kacper Kornet
2011-04-28 21:05 ` Junio C Hamano
2011-04-28 21:22 ` Kacper Kornet
2011-05-03 6:42 ` [PATCH 1/1] Honor $(prefix) set in config.mak* when defining ETC_GIT* and sysconfdir Johannes Sixt
2011-05-03 17:32 ` Junio C Hamano
2011-05-04 5:52 ` Johannes Sixt
2011-05-04 13:58 ` Kacper Kornet
2011-05-04 14:39 ` Johannes Sixt
2011-05-04 18:21 ` Junio C Hamano
2011-05-05 2:26 ` Junio C Hamano
2011-05-05 5:58 ` Johannes Sixt
2011-05-05 16:17 ` Junio C Hamano
2011-05-06 7:03 ` Johannes Sixt
2011-05-05 14:29 ` Kacper Kornet [this message]
2011-05-05 14:45 ` Johannes Sixt
2011-05-05 15:00 ` Kacper Kornet
2011-05-05 15:46 ` Junio C Hamano
2011-05-09 8:24 ` Johannes Sixt
2011-05-09 11:56 ` Kacper Kornet
2011-05-27 8:17 ` Kacper Kornet
2011-05-05 15:25 ` Kacper Kornet
2011-05-04 14:29 ` Kacper Kornet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110505142910.GA31229@camk.edu.pl \
--to=kornet@camk.edu.pl \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=j.sixt@viscovery.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).