From: Kacper Kornet <draenog@pld-linux.org>
To: git@vger.kernel.org
Subject: [PATCH] t1507: change quoting in test_did_you_mean to a more general one
Date: Thu, 5 May 2011 21:10:28 +0200 [thread overview]
Message-ID: <20110505191027.GA3242@camk.edu.pl> (raw)
In bash and some other shells the script:
x=2; unset a; echo "${a:-'$x'}"
prints '2'. However ksh shell prints $x. The quoting is added to
reproduce bash behaviour.
Signed-off-by: Kacper Kornet <draenog@pld-linux.org>
---
t/t1506-rev-parse-diagnosis.sh | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/t/t1506-rev-parse-diagnosis.sh b/t/t1506-rev-parse-diagnosis.sh
index 4a6396f..bad09f9 100755
--- a/t/t1506-rev-parse-diagnosis.sh
+++ b/t/t1506-rev-parse-diagnosis.sh
@@ -8,8 +8,8 @@ exec </dev/null
test_did_you_mean ()
{
- printf "fatal: Path '$2$3' $4, but not ${5:-'$3'}.\n" >expected &&
- printf "Did you mean '$1:$2$3'${2:+ aka '$1:./$3'}?\n" >>expected &&
+ printf "fatal: Path '$2$3' $4, but not ${5:-\'$3\'}.\n" >expected &&
+ printf "Did you mean '$1:$2$3'${2:+ aka \'$1:./$3\'}?\n" >>expected &&
test_cmp expected error
}
--
1.7.5
--
Kacper Kornet
next reply other threads:[~2011-05-05 19:10 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-05 19:10 Kacper Kornet [this message]
2011-05-05 20:02 ` [PATCH] t1507: change quoting in test_did_you_mean to a more general one Junio C Hamano
2011-05-06 7:43 ` Michael J Gruber
2011-05-06 8:51 ` Kacper Kornet
2011-05-06 9:14 ` Michael J Gruber
2011-05-06 10:22 ` Johannes Sixt
2011-05-06 11:10 ` Michael J Gruber
2011-05-06 14:23 ` Junio C Hamano
2011-05-09 4:40 ` Junio C Hamano
2011-05-09 6:39 ` Johannes Sixt
2011-05-09 16:20 ` Junio C Hamano
2011-05-06 8:39 ` Kacper Kornet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110505191027.GA3242@camk.edu.pl \
--to=draenog@pld-linux.org \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).